feat: complete previous work before finishing test case between Axon and Ckb #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 4, 2023 20:25
ashuralyk
changed the title
ashuralyk
changed the title
|
after merging this, I can start my work on the finish of Axon <> ckb case, based on the |
jjyr
reviewed
Jul 10, 2023
Flouse
requested changes
Jul 12, 2023
Flouse
requested changes
Jul 12, 2023
bug: fix connection number error from Ckb endpoint
ashuralyk
changed the title
jjyr
reviewed
Jul 13, 2023
ashuralyk
force-pushed
the
feat/finish-ckb-packet-feature
branch
2 times, most recently
from
32ed9c8 to
7d7fbe8
Compare
ashuralyk
force-pushed
the
feat/finish-ckb-packet-feature
branch
from
7d7fbe8 to
d1057ee
Compare
jjyr
reviewed
Jul 18, 2023
jjyr
approved these changes
Jul 19, 2023
Flouse
reviewed
Jul 19, 2023
| .rt | ||
| .block_on(self.get_proofs_ingredients(block_number))?; | ||
|
|
||
| // FIXME: keep it commentted until Axon team fixed this verify issue |
There was a problem hiding this comment.
Suggested change
| // FIXME: keep it commentted until Axon team fixed this verify issue | |
| // FIXME: keep it commentted until Axon team fixed this verify issue | |
| // See https://github.com/axonweb3/axon/issues/1260 |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #256 #195
Description
this PR aims to optimize and complete the previous commit of connection and channel test cases of Forcerelay/Axon, because I found that Ckb endpoint missed one command to finish and Axon endpoint needs to add more code to pass test
ps. Some internal runtime from Hermes framework is not applicable to our Axon and Ckb endpoint for the non-compatible case, so the process on
Heightand other variables looks a little weirdPR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.