Skip to content

feat: add granitemoeshared and granitemoehybrid to multipack#3158

Merged
NanoCode012 merged 1 commit into
mainfrom
feat/granitehybrid
Nov 10, 2025
Merged

feat: add granitemoeshared and granitemoehybrid to multipack#3158
NanoCode012 merged 1 commit into
mainfrom
feat/granitehybrid

Conversation

@NanoCode012
Copy link
Copy Markdown
Collaborator

@NanoCode012 NanoCode012 commented Sep 12, 2025

Description

Make sure to install axolotl-ai-cloud/ml-cross-entropy#24

Motivation and Context

How has this been tested?

Screenshots (if appropriate)

Types of changes

Social Handles (Optional)

Summary by CodeRabbit

  • New Features
    • Added support for two new model variants, expanding the range of supported model configurations for multipack processing.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Sep 12, 2025

📝 Walkthrough

Walkthrough

This pull request adds two new model type identifiers—"granitemoeshared" and "granitemoehybrid"—to the SUPPORTED_MULTIPACK_MODEL_TYPES list in the multipack monkeypatch module, extending support for Granite model variants.

Changes

Cohort / File(s) Summary
Adding Granite model type identifiers
src/axolotl/monkeypatch/multipack.py
Added "granitemoeshared" and "granitemoehybrid" to SUPPORTED_MULTIPACK_MODEL_TYPES list

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5–10 minutes

  • Verify that "granitemoeshared" and "granitemoehybrid" are the correct model type identifiers
  • Ensure consistency with how other model types are named and registered in the list

Possibly related PRs

Suggested labels

ready to merge

Suggested reviewers

  • winglian
  • SalmanMohammadi

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and specifically describes the main change: adding two new model type strings (granitemoeshared and granitemoehybrid) to the supported multipack model types.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/granitehybrid

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 58d67bf and 1075291.

📒 Files selected for processing (1)
  • src/axolotl/monkeypatch/multipack.py (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: PyTest (3.11, 2.8.0)
  • GitHub Check: PyTest (3.11, 2.9.0)
  • GitHub Check: PyTest (3.11, 2.7.1)
  • GitHub Check: PyTest from Source Dist (3.11, 2.7.1)
  • GitHub Check: PyTest from Source Dist (3.11, 2.8.0)
  • GitHub Check: PyTest from Source Dist (3.11, 2.9.0)
🔇 Additional comments (1)
src/axolotl/monkeypatch/multipack.py (1)

41-42: Add Liger kernel support for new Granite MoE variants or clarify if intentional.

The new models granitemoeshared and granitemoehybrid are added to SUPPORTED_MULTIPACK_MODEL_TYPES, but they're missing from the Liger kernel integration in src/axolotl/integrations/liger/plugin.py. The existing granitemoe model has explicit Liger kernel support via apply_liger_kernel_to_granite() at lines 156–159.

If these new models are MoE variants (as their names suggest), they should receive the same treatment. Either:

  • Add the new models to the Liger plugin's Granite MoE handling, or
  • Clarify if Liger support is deferred to the dependency PR mentioned in the description

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@NanoCode012 NanoCode012 marked this pull request as ready for review November 10, 2025 14:33
@NanoCode012 NanoCode012 changed the title feat: add granitemoeshared and granitemoehybrid feat: add granitemoeshared and granitemoehybrid to multipack Nov 10, 2025
@NanoCode012 NanoCode012 merged commit d0c846f into main Nov 10, 2025
16 of 17 checks passed
@NanoCode012 NanoCode012 deleted the feat/granitehybrid branch November 10, 2025 14:35
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant