Feat: add qwen3_vl, qwen3_vl_moe, granitemoeshared, granitemoehybrid, and upgraded all cce patches#3178
Conversation
📝 WalkthroughWalkthroughUpdates the pinned git commit for ml-cut-cross-entropy installation from c5aa3ef to 147ea28 across notebook, script, and init message. The README also updates the install hash and expands the Supported Models list with additional entries. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
📖 Documentation Preview: https://68d37e3c230072294bb4a8d9--resonant-treacle-0fd729.netlify.app Deployed on Netlify from commit 0b0f37c |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
src/axolotl/integrations/cut_cross_entropy/__init__.py (1)
36-39: Avoid future drift: centralize the pinned CCE revision.The SHA appears in multiple places (here, install script, README). Consider centralizing it (e.g., a small internal constant module or config) and referencing it to prevent future mismatches.
scripts/cutcrossentropy_install.py (2)
32-32: Pin bump acknowledged; consider env-agnostic invocation.String looks correct. Optionally prefer python -m pip (and uv pip) consistently to avoid PATH/env issues.
Apply within this line if desired:
-+ f'{UV_PREFIX}pip install "cut-cross-entropy[transformers] @ git+https://github.com/axolotl-ai-cloud/ml-cross-entropy.git@147ea28"' ++ f'{UV_PREFIX}python -m pip install "cut-cross-entropy[transformers] @ git+https://github.com/axolotl-ai-cloud/ml-cross-entropy.git@147ea28"'Note: When USE_UV is true, this becomes: uv python -m pip install ... which is also supported by uv.
23-33: Uninstall condition may miss non-fork installs with transformers extra.If cut_cross_entropy is installed with transformers extra but is not Axolotl’s fork, we won’t uninstall and will re-install on top. Consider always uninstalling before reinstalling to ensure the fork is used.
-if cce_spec: - if not importlib.util.find_spec("cut_cross_entropy.transformers"): - UNINSTALL_PREFIX = "pip uninstall -y cut-cross-entropy && " +if cce_spec: + # Always uninstall to avoid mixed installations across forks/extras + UNINSTALL_PREFIX = "pip uninstall -y cut-cross-entropy && "examples/colab-notebooks/colab-axolotl-example.ipynb (2)
40-44: Align Colab env with Transformers 4.56.2 to match upgraded patches.To avoid resolver drift on Colab and ensure compatibility with the upgraded patches, pin Transformers in the install cell.
Apply this diff:
%%capture # This step can take ~5-10 minutes to install dependencies !pip install --no-build-isolation axolotl[flash-attn]>=0.9.1 +!pip install "transformers==4.56.2" !pip install "cut-cross-entropy[transformers] @ git+https://github.com/axolotl-ai-cloud/ml-cross-entropy.git@147ea28"
40-44: Prefer fully pinned versions in notebooks for reproducibility.Colab environments change frequently. Consider pinning axolotl to an exact version used by this PR to prevent breakages from future releases.
Example:
-!pip install --no-build-isolation axolotl[flash-attn]>=0.9.1 +!pip install --no-build-isolation "axolotl[flash-attn]==0.9.1"
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
examples/colab-notebooks/colab-axolotl-example.ipynb(1 hunks)scripts/cutcrossentropy_install.py(1 hunks)src/axolotl/integrations/cut_cross_entropy/README.md(4 hunks)src/axolotl/integrations/cut_cross_entropy/__init__.py(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: docker-e2e-tests-1st (126, 12.6.3, 3.11, 2.7.1, 1)
- GitHub Check: docker-e2e-tests-1st (126, 12.6.3, 3.11, 2.7.1, 1, Dockerfile-uv.jinja)
🔇 Additional comments (4)
src/axolotl/integrations/cut_cross_entropy/README.md (2)
22-22: Install line matches code/scripts; verify repo-wide consistency.Looks good. Please ensure no references to the old SHA remain elsewhere.
Use the script shared in the init.py comment to confirm both the commit’s existence and that all occurrences are updated.
34-75: Verify PATCH_FNS registration for newly documented models.
Couldn't fetch cut_cross_entropy/transformers/patch.py at axolotl-ai-cloud/ml-cross-entropy@147ea28 (gh returned 404); confirm PATCH_FNS contains keys for: apertus, glm4v, glm4v_moe, granitemoeshared, granitemoehybrid, qwen3_vl, qwen3_vl_moe — or confirm the generic patch path reliably covers them.src/axolotl/integrations/cut_cross_entropy/__init__.py (1)
38-38: Pin bump OK — commit 147ea28 found; verify patch APIcut_cross_entropy/transformers/patch.py@147ea28 defines AXOLOTL_CCE_FORK but does not define register_patch/apply_patch/patch (it exposes a PATCH_FNS mapping); confirm the integration uses the mapping or update the code to match upstream.
examples/colab-notebooks/colab-axolotl-example.ipynb (1)
43-43: CCE pin bump to 147ea28 — no stale c5aa3ef references found (LGTM)rg returned no matches for old SHA c5aa3ef and found expected occurrences of 147ea28 in: scripts/cutcrossentropy_install.py, src/axolotl/integrations/cut_cross_entropy/init.py, src/axolotl/integrations/cut_cross_entropy/README.md, and examples/colab-notebooks/colab-axolotl-example.ipynb.
Description
Motivation and Context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Social Handles (Optional)
Summary by CodeRabbit
Documentation
Chores