add 2.7.0 torch images back to support vlllm by winglian · Pull Request #2885 · axolotl-ai-cloud/axolotl

winglian · 2025-07-08T19:16:57Z

vllm is pinned to torch==2.7.0, so we can't ship them with our torch 2.7.1 images.

Summary by CodeRabbit

Chores
- Expanded build configurations to include support for PyTorch 2.7.0 with CUDA 12.6.3 and Python 3.11 in automated workflows.
- Updated package requirements to use xformers==0.0.31.post1 for PyTorch 2.7+ and set vllm to require version 0.9.0 or higher.

coderabbitai · 2025-07-08T19:17:03Z

Walkthrough

The changes introduce PyTorch 2.7.0 as a supported version in GitHub Actions workflow matrices for various build jobs and update package version constraints in setup.py for compatibility with PyTorch 2.7.x. No modifications were made to exported code entities or workflow logic.

Changes

File(s)	Summary
.github/workflows/base.yml	Added a new matrix entry for CUDA 12.6.3, Python 3.11, and PyTorch 2.7.0 in `build-base`.
.github/workflows/main.yml	Added new matrix entries for PyTorch 2.7.0 with CUDA 12.6.3 and Python 3.11 in two jobs.
setup.py	Updated `xformers` to 0.0.31.post1 for PyTorch 2.7+, and set `vllm` to minimum 0.9.0.

Sequence Diagram(s)

sequenceDiagram
    participant GitHub Actions
    participant Workflow Matrix
    participant Setup.py

    GitHub Actions->>Workflow Matrix: Expand build jobs (add PyTorch 2.7.0 configs)
    Workflow Matrix-->>GitHub Actions: Provide new matrix entries

    GitHub Actions->>Setup.py: Install dependencies
    Setup.py->>Setup.py: Detect PyTorch version
    alt PyTorch >= 2.7
        Setup.py->>Setup.py: Pin xformers==0.0.31.post1
        Setup.py->>Setup.py: Set vllm>=0.9.0
    else
        Setup.py->>Setup.py: Use previous constraints
    end

Possibly related PRs

build base images for torch 2.7.1 #2764: Updates build configurations and Dockerfiles from PyTorch 2.7.0 to 2.7.1, continuing the version support work.
build 2.7.1 images and ci #2784: Updates workflow entries from PyTorch 2.7.0 to 2.7.1, modifying the same files and configurations.

Suggested labels

ready to merge

Suggested reviewers

NanoCode012
djsaunde

Poem

A new PyTorch hops into the mix,
With CUDA and Python, a clever new fix.
xformers and vllm get shiny new pins,
The matrix expands and the building begins!
🐇 CI bounces, dependencies align—
Another smooth update, all by design!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8c6a6ea and c68ffb5.

📒 Files selected for processing (3)

.github/workflows/base.yml (1 hunks)
.github/workflows/main.yml (2 hunks)
setup.py (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: NanoCode012
PR: axolotl-ai-cloud/axolotl#2854
File: README.md:73-77
Timestamp: 2025-07-02T02:56:20.788Z
Learning: For Axolotl Docker commands, the `--ipc=host` flag should be included by default to prevent shared memory failures that commonly occur with PyTorch DataLoaders and multiprocessing during machine learning training workflows.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (15)

GitHub Check: build-base (128, 12.6.3, 3.11, 2.7.1, 7.0 7.5 8.0 8.6 8.7 8.9 9.0+PTX, Dockerfile-base)
GitHub Check: build-base (126, 12.6.3, 3.11, 2.7.1, 7.0 7.5 8.0 8.6 8.7 8.9 9.0+PTX, Dockerfile-base)
GitHub Check: PyTest from Source Dist (3.11, 2.6.0)
GitHub Check: build-base (126, 12.6.3, 3.11, 2.6.0, 7.0 7.5 8.0 8.6 8.7 8.9 9.0+PTX, Dockerfile-base)
GitHub Check: PyTest from Source Dist (3.11, 2.7.1)
GitHub Check: build-base-uv (126, 12.6.3, 3.11, 2.6.0, 7.0 7.5 8.0 8.6 8.7 8.9 9.0+PTX, Dockerfile-uv-base)
GitHub Check: build-base (124, 12.4.1, 3.11, 2.5.1, 7.0 7.5 8.0 8.6 8.7 8.9 9.0+PTX, Dockerfile-base)
GitHub Check: build-base (126, 12.6.3, 3.11, 2.7.0, 7.0 7.5 8.0 8.6 8.7 8.9 9.0+PTX, Dockerfile-base)
GitHub Check: PyTest from Source Dist (3.11, 2.5.1)
GitHub Check: build-base-uv (128, 12.8.1, 3.11, 2.7.1, 7.0 7.5 8.0 8.6 8.7 8.9 9.0+PTX, Dockerfile-uv-base)
GitHub Check: PyTest (3.11, 2.6.0)
GitHub Check: PyTest (3.11, 2.7.1)
GitHub Check: pre-commit
GitHub Check: PyTest (3.11, 2.5.1)
GitHub Check: pre-commit

🔇 Additional comments (4)

setup.py (1)

69-70: Dependency compatibility confirmed for PyTorch 2.7+

xformers==0.0.31.post1 requires (and is built for) PyTorch ≥ 2.7.0

vLLM ≥ 0.9.0 is the minimum stable release supporting PyTorch 2.7.0

Both constraints align with the PR’s goal of PyTorch 2.7+ support—no further changes needed.

.github/workflows/main.yml (2)

28-32: LGTM! PyTorch 2.7.0 matrix entry is properly configured.

The new matrix entry for PyTorch 2.7.0 with vLLM extras is well-positioned and consistent with the PR objective of supporting vLLM with PyTorch 2.7.0.

101-105: LGTM! Consistent PyTorch 2.7.0 configuration for cloud builds.

The new matrix entry for build-axolotl-cloud follows the established pattern and is properly configured for PyTorch 2.7.0 support.

.github/workflows/base.yml (1)

49-55: LGTM! Base image matrix entry is properly configured.

The new PyTorch 2.7.0 matrix entry is consistent with the established pattern and properly configured for base image builds.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-07-08T19:25:17Z

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

NanoCode012 · 2025-07-10T10:41:05Z

I don't think I see vllm images being built, only normal version @winglian

https://hub.docker.com/r/axolotlai/axolotl-cloud/tags

add 2.7.0 torch images back to support vlllm

c68ffb5

winglian merged commit 6ed501f into main Jul 8, 2025
18 of 24 checks passed

winglian deleted the 2.7.0-images branch July 8, 2025 20:28

coderabbitai Bot mentioned this pull request Jul 17, 2025

cu126-torch271 for cloud docker image should be tagged with main-latest #2935

Merged

coderabbitai Bot mentioned this pull request Jul 27, 2025

upgrade to support latest transformers release #2984

Merged

coderabbitai Bot mentioned this pull request Jan 6, 2026

upgrade vllm to v0.14.0 #3345

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add 2.7.0 torch images back to support vlllm#2885

add 2.7.0 torch images back to support vlllm#2885
winglian merged 1 commit into
mainfrom
2.7.0-images

winglian commented Jul 8, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 8, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov Bot commented Jul 8, 2025

Uh oh!

Uh oh!

NanoCode012 commented Jul 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

winglian commented Jul 8, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov Bot commented Jul 8, 2025

Codecov Report

Uh oh!

Uh oh!

NanoCode012 commented Jul 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

winglian commented Jul 8, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 8, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)