build base images for torch 2.7.1#2764
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThe PyTorch version was updated from 2.7.0 to 2.7.1 across multiple components: the GitHub Actions CI/CD workflow, Docker base images, and related documentation. The update affects the build matrix, conditional package installation, Dockerfile installations, and recommended Docker image tags for Blackwell GPUs. Additionally, a timeout was added to CI jobs, and the Changes
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
.github/workflows/base.yml (1)
121-127: 💡 Verification agent🧩 Analysis chain
Upgrade PyTorch version to 2.7.1 for UV base image
Thebuild-base-uvjob now targets PyTorch 2.7.1 on CUDA 12.8.1. Verify thatdocker/Dockerfile-uv-baseconsumes thePYTORCH_VERSIONbuild-arg so this bump is applied.
🏁 Script executed:
#!/bin/bash # Verify Dockerfile-uv-base uses the PYTORCH_VERSION build argument grep -R "ARG PYTORCH_VERSION" docker/Dockerfile-uv-base grep -R "PYTORCH_VERSION" docker/Dockerfile-uv-baseLength of output: 215
Update default PyTorch version in Dockerfile-uv-base
The Dockerfile already consumes
PYTORCH_VERSION, but its default remains at2.6.0. Please bump it to match the workflow’s 2.7.1 target.• File: docker/Dockerfile-uv-base
- ARG PYTORCH_VERSION="2.6.0" + ARG PYTORCH_VERSION="2.7.1"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/base.yml(2 hunks)
🔇 Additional comments (1)
.github/workflows/base.yml (1)
53-59: Upgrade PyTorch version to 2.7.1 for CUDA 12.8.1
The matrix entry for CUDA 12.8.1 has been bumped to PyTorch 2.7.1. Confirm thatdocker/Dockerfile-basepicks up this version via thePYTORCH_VERSIONbuild-arg.Use the same verification script as above to ensure the Dockerfile references
PYTORCH_VERSION.
| python_version: "3.11" | ||
| pytorch: 2.7.0 | ||
| pytorch: 2.7.1 | ||
| torch_cuda_arch_list: "7.0 7.5 8.0 8.6 8.7 8.9 9.0+PTX" | ||
| dockerfile: "Dockerfile-base" |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Upgrade PyTorch version to 2.7.1 for CUDA 12.6.3
This matrix entry now targets PyTorch 2.7.1 under CUDA 12.6.3 and Python 3.11, matching the PR’s goal. Please verify that docker/Dockerfile-base correctly consumes the PYTORCH_VERSION build-arg so the image actually uses 2.7.1.
🏁 Script executed:
#!/bin/bash
# Verify Dockerfile-base uses the PYTORCH_VERSION build argument
grep -R "ARG PYTORCH_VERSION" docker/Dockerfile-base
grep -R "PYTORCH_VERSION" docker/Dockerfile-baseLength of output: 365
Update Dockerfile-base default PyTorch version to 2.7.1
The workflow matrix now installs PyTorch 2.7.1, but docker/Dockerfile-base still defaults to 2.1.2. Please update the build-arg and any related conditionals so the image actually uses 2.7.1:
• File: docker/Dockerfile-base
- Change the default ARG:
- ARG PYTORCH_VERSION="2.1.2" + ARG PYTORCH_VERSION="2.7.1"
- Update any version checks (e.g.
if [ "$PYTORCH_VERSION" = "2.7.0" ]) to2.7.1or remove if no longer needed.
Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In docker/Dockerfile-base around the ARG PYTORCH_VERSION declaration and any
conditional logic checking the PyTorch version, update the default
PYTORCH_VERSION build-arg from 2.1.2 to 2.7.1. Also, modify or remove any
version-specific conditionals that check for 2.7.0 to reflect 2.7.1 or to
simplify if those checks are no longer necessary. This ensures the Docker image
build uses PyTorch 2.7.1 as specified in the workflow matrix.
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
winglian
force-pushed
the
torch-2.7.1-base
branch
from
9bdf279 to
90b6c18
Compare
2 participants
PyTorch 2.7.1 is out! Adds base docker image builds replacing 2.7.0
Summary by CodeRabbit