Fix integration test failures on non-x86 #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turan18
force-pushed
the
integ_non_x86
branch
3 times, most recently
from
566c8ff to
3ab2158
Compare
There were several issues that caused integration tests to fail on non-x86. The first one was our dependency GHCR registry image which is only supported on amd64. The GHCR registry was needed when we supported artifact manifests, but those have been seemingly removed from the OCI 1.1 spec proposal, so we no longer need it. We also had 2 tests that relied on a pinned amd64 variant of rabbitmq. Those have been replaced with a pinned multi-arch index. Signed-off-by: Yasin Turan <[email protected]>
Kern--
approved these changes
Aug 29, 2023
Created #808 |
henry118
approved these changes
Aug 30, 2023
This was referenced Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several issues that caused integration tests to fail on non-x86. The first one was our dependency GHCR registry image which is only supported on amd64. The GHCR registry was needed when we supported artifact manifests, but those have been seemingly removed from the OCI 1.1 spec proposal, so we no longer need it. We also had 2 tests that relied on a pinned amd64 variant of rabbitmq. Those have been replaced with a pinned multi-arch index.
Issue #, if available:
Fixes: #696
Description of changes:
Testing performed:
Spin up an ARM64 instance and run integration tests.
$ uname -p aarch64 $ make integration .... --- PASS: TestSociZtocGetFile/Ztoc_and_each_file_exists,_file_contents_redirected_to_output_file#03 (0.09s) PASS ok github.com/awslabs/soci-snapshotter/integration 1032.225sBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.