-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Integration tests don't work on non-x86 #696
Comments
Those tags should be historic and static, not versions that might see backports or other new pushes. |
For the second issue, I think we can just skip that test on ARM for now. |
@Kern-- Just skipping the test that uses the 1.1 registry is not sufficient. The image and container in question are also used in soci-snapshotter/integration/main_test.go Line 129 in bde429d
Also the Dockerfile will need to be modified to not attempt to pull the image in question on the wrong arch. I'd like to discuss re-estimating this. |
For the third task, the digest can be replaced with a tag for use in calculating the |
Description
Our integration tests fail on other architectures. Here are some things we need to do to:
TARGETARCH
is not honored since it is not scoped locally. This causes us to use only amd64 artifacts. - Set TARGETARCH as a build ARG #695soci-snapshotter/integration/push_test.go
Line 133 in 801acef
soci-snapshotter/integration/util_test.go
Line 423 in 801acef
Steps to reproduce the bug
Run the integration tests on non x86 arch.
Describe the results you expected
Integration tests should work with different architectures.
Host information
Any additional context or information about the bug
No response
The text was updated successfully, but these errors were encountered: