Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Integration tests don't work on non-x86 #696

Closed
3 tasks done
turan18 opened this issue Jun 30, 2023 · 4 comments · Fixed by #806
Closed
3 tasks done

[Bug] Integration tests don't work on non-x86 #696

turan18 opened this issue Jun 30, 2023 · 4 comments · Fixed by #806
Labels
bug Something isn't working

Comments

@turan18
Copy link
Contributor

turan18 commented Jun 30, 2023

Description

Our integration tests fail on other architectures. Here are some things we need to do to:

Steps to reproduce the bug

Run the integration tests on non x86 arch.

Describe the results you expected

Integration tests should work with different architectures.

Host information

  1. OS:
  2. Snapshotter Version:
  3. Containerd Version:

Any additional context or information about the bug

No response

@turan18 turan18 added the bug Something isn't working label Jun 30, 2023
@sparr
Copy link
Contributor

sparr commented Jun 30, 2023

We have 2 tests that specifically use an amd64 variant of rabbitmq- [...] We should change them to use tags that support multiple architectures.

Those tags should be historic and static, not versions that might see backports or other new pushes.

@Kern--
Copy link
Contributor

Kern-- commented Jul 5, 2023

For the second issue, I think we can just skip that test on ARM for now.

@github-project-automation github-project-automation bot moved this to ❓ Ungroomed in soci-snapshotter Jul 5, 2023
@Kern-- Kern-- moved this from ❓ Ungroomed to 📋 Backlog in soci-snapshotter Jul 5, 2023
@sparr sparr self-assigned this Aug 9, 2023
@sparr
Copy link
Contributor

sparr commented Aug 9, 2023

@Kern-- Just skipping the test that uses the 1.1 registry is not sufficient. The image and container in question are also used in composeBuildTemplate which is used in TestMain's call to setup().

Registry3Alpha1Stage: registry3alpha1Stage,
This can probably also be skipped on other arch, but is nontrivial.

Also the Dockerfile will need to be modified to not attempt to pull the image in question on the wrong arch.

I'd like to discuss re-estimating this.

@sparr sparr removed their assignment Aug 9, 2023
@sparr
Copy link
Contributor

sparr commented Aug 9, 2023

For the third task, the digest can be replaced with a tag for use in calculating the imgRef, but a bit more logic will be required to get the digest for the fetched tag for use in buildMaliciousIndex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants