Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add authentication to the fetch tokens from code #9

Merged
merged 2 commits into from
Sep 15, 2021

Conversation

yoavya
Copy link
Contributor

@yoavya yoavya commented Aug 4, 2021

Issue #7

  • allow cognito app with secret in case that the cognito app has a secret
  • app secret can now be received in params as userPoolAppSecret

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

 - in case that the cognito app has a secret
 - app secret can now be received in params
Copy link
Contributor

@jeandek jeandek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yoavya , thanks for submitting this PR. Apart from a minor documentation issue (see my inline comment) it looks good and ready to be merged.

I run some tests tomorrow to make sure, but I don't foresee any issues.

README.md Outdated Show resolved Hide resolved
@yoavya
Copy link
Contributor Author

yoavya commented Aug 5, 2021

fixed documentation

@jeandek jeandek merged commit 4601d2b into awslabs:main Sep 15, 2021
@jeandek
Copy link
Contributor

jeandek commented Sep 15, 2021

Just tested your changes and they work perfectly. Thanks @yoavya and my apologies for the delay in merging this.

@jeandek jeandek added this to the v1.1.0 milestone Sep 15, 2021
@jeandek jeandek added the feature-request New feature or request label Sep 15, 2021
@jeandek jeandek added added-feature For PRs which containg a new feature (may be in response to a `feature-request`) and removed feature-request New feature or request labels Oct 5, 2021
@yoavya yoavya deleted the authentication-secret branch March 23, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added-feature For PRs which containg a new feature (may be in response to a `feature-request`)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants