Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cognito client Id with secret #7

Closed
yoavya opened this issue Jul 27, 2021 · 3 comments
Closed

Cognito client Id with secret #7

yoavya opened this issue Jul 27, 2021 · 3 comments
Labels
feature-request New feature or request
Milestone

Comments

@yoavya
Copy link
Contributor

yoavya commented Jul 27, 2021

It seems like this package doesn't support a cognito user pool client with secret.
according to cognito documentation when the client has a secret it must be passed through the authentication header

Authorization

If the client was issued a secret, the client must pass its client_id and client_secret in the authorization header through Basic HTTP authorization. The secret is Basic
Base64Encode(client_id:client_secret). 

currently I am able to use this package only with cognito user pool clients that don't have a secret id
it would be nice to be able to use both options :)

@jeandek jeandek added the feature-request New feature or request label Jul 27, 2021
@jeandek
Copy link
Contributor

jeandek commented Jul 27, 2021

Hi yoavya,
I have not tried to use the package with the setup you describe, but according to the documentation you linked it makes sense that the package doesn't work in that situation. This is definitely something that should be supported. I'll add it to our backlog.

@yoavya
Copy link
Contributor Author

yoavya commented Aug 4, 2021

Hi, I opened a PR ☝🏼 to fix this, already checked on my cognito app that it works.

@jeandek jeandek added this to the v1.1.0 milestone Sep 15, 2021
@jeandek
Copy link
Contributor

jeandek commented Sep 15, 2021

PR was merged and will be included in 1.0.0. Thanks yoavya.

@jeandek jeandek closed this as completed Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants