Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript support #26

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Conversation

piotrekwitkowski
Copy link
Contributor

@piotrekwitkowski piotrekwitkowski commented Jan 11, 2022

Issue #20

Description of changes:

  • installed typescript dependency, added tsconfig.json
  • moved index.js to src/index.ts, changed imports to typescript-style and fixed ts compiler errors
  • added typings information to package.json
  • adjusted eslint to work with typescript source and made sure there are no linting warnings or errors
  • adjusted jest to be able to parse ts file in the new location and made sure all tests pass

Other things to be considered:

  • with the current tsc configuration the js file will be generated in the dist folder and will not be available (like before - ready to use in the js format) in the project's root. I added dist to .gitignore, but if the previous behavior is desired, the tsconfig.json and package.json can of course be modified to reflect this

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jeandek jeandek requested a review from pedromgarcia January 12, 2022 08:33
Copy link
Contributor

@pedromgarcia pedromgarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @piotrekwitkowski,

Thanks for submitting this PR, everything looks good so we will merge the changes and publish a new version.

@pedromgarcia pedromgarcia merged commit c01ef99 into awslabs:main Jan 12, 2022
@pedromgarcia
Copy link
Contributor

Resolving #20

@pedromgarcia pedromgarcia linked an issue Jan 12, 2022 that may be closed by this pull request
@piotrekwitkowski piotrekwitkowski deleted the feat/typescript branch January 13, 2022 11:18
@jeandek jeandek added this to the 1.2.0 milestone Jan 17, 2022
@jeandek jeandek added the added-feature For PRs which containg a new feature (may be in response to a `feature-request`) label Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added-feature For PRs which containg a new feature (may be in response to a `feature-request`)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to typescript
3 participants