Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to typescript #20

Closed
eddie-atkinson opened this issue Dec 16, 2021 · 2 comments · Fixed by #26
Closed

Switch to typescript #20

eddie-atkinson opened this issue Dec 16, 2021 · 2 comments · Fixed by #26
Labels
feature-request New feature or request
Milestone

Comments

@eddie-atkinson
Copy link

What would you like to be added:

I am filing this issue to gauge the interest of the maintainers of this project in switching to Typescript. I have found this project useful in my own work and think it would be a big QoL improvement if it were type annotated.

I also wanted to gauge how responsive the maintainers of this project would be to PRs to add functionality. For my use case I'd love to add a callback to the handle function which allows me to change the return logic on the basis of a user's decoded token. For example, to return a 403 error if a user doesn't have a Cognito group granting them access.

Why is this needed:

  • Given how long it takes to redeploy Lambda@Edge functions, catching silly errors at compile time would improve DX a lot
@jeandek
Copy link
Contributor

jeandek commented Dec 16, 2021

Hi @eddie-atkinson,

Switching to Typescript is definitely something we'd like to do, though I can't commit to a specific roadmap.

We're open to PRs for both bug fixes and new functionality. For the latter, we recommend that you reach out to us to make sure this is something we'd be interested in adding. Your proposal would be a worthwhile addition to the package, we'd definitely be interested.

Cheers,
Jean

@pedromgarcia
Copy link
Contributor

Hi @piotrekwitkowski,

Thanks for the PR, changes has been merged and will be included in the next release.

@pedromgarcia pedromgarcia linked a pull request Jan 12, 2022 that will close this issue
@jeandek jeandek added this to the 1.2.0 milestone Jan 17, 2022
@jeandek jeandek added the feature-request New feature or request label Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants