Addressing FileUtils::ExtractExpandedPath failure #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoemorais-aws
suggested changes
Jul 1, 2022
shangabl
reviewed
Jul 6, 2022
marcoemorais-aws
suggested changes
Jul 6, 2022
shangabl
reviewed
Jul 7, 2022
HarshGandhi-AWS
requested changes
Jul 7, 2022
marcoemorais-aws
previously approved these changes
Jul 7, 2022
shangabl
previously approved these changes
Jul 7, 2022
HarshGandhi-AWS
previously approved these changes
Jul 7, 2022
marcoemorais-aws
previously approved these changes
Jul 7, 2022
adanforth
changed the title
shangabl
dismissed stale reviews from marcoemorais-aws, HarshGandhi-AWS, and themself
via
7373788
adanforth
force-pushed
the
adanfo
branch
2 times, most recently
from
446839f
to
703b66d
Compare
marcoemorais-aws
approved these changes
Jul 8, 2022
shangabl
approved these changes
Jul 8, 2022
RogerZhongAWS
approved these changes
Jul 8, 2022
fixed linter issues added logic for checking ExtractExpandedPath failures Added/Fixed some tests and a typo fixed test fixed bugs and added style changes fixed linter issues fixed repeated code, capitalization, and removed TODO comment Removed redundant code, added formatting for error messages, updated shadow file size/readme fixed error message fixed test fixed repeated code, capitalization, and removed TODO comment Removed redundant code, added formatting for error messages, updated shadow file size/readme fixed error message Added more specific error messages
joenghoyin
pushed a commit
to eguanatech/aws-iot-device-client-deprecated
that referenced
this pull request
Aug 29, 2023
fixed linter issues added logic for checking ExtractExpandedPath failures Added/Fixed some tests and a typo fixed test fixed bugs and added style changes fixed linter issues fixed repeated code, capitalization, and removed TODO comment Removed redundant code, added formatting for error messages, updated shadow file size/readme fixed error message fixed test fixed repeated code, capitalization, and removed TODO comment Removed redundant code, added formatting for error messages, updated shadow file size/readme fixed error message Added more specific error messages
joenghoyin
pushed a commit
to eguanatech/aws-iot-device-client-deprecated
that referenced
this pull request
Aug 30, 2023
fixed linter issues added logic for checking ExtractExpandedPath failures Added/Fixed some tests and a typo fixed test fixed bugs and added style changes fixed linter issues fixed repeated code, capitalization, and removed TODO comment Removed redundant code, added formatting for error messages, updated shadow file size/readme fixed error message fixed test fixed repeated code, capitalization, and removed TODO comment Removed redundant code, added formatting for error messages, updated shadow file size/readme fixed error message Added more specific error messages # Conflicts: # source/fleetprovisioning/FleetProvisioning.cpp # test/config/TestConfig.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
wordexpin implementation of FileUtils::ExtractExpandedPath #203Modifications
Change summary
Added brief check on the return value of wordexp. Upon receiving a bad status code, return a sentinel value indicating failure. Also added documentation of this behavior on the function description.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.