Placeholder input validation #287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlcheng1
requested review from
marcoemorais-aws,
HarshGandhi-AWS,
RogerZhongAWS,
BolongZhang-AWS and
shangabl
| @@ -1047,22 +1040,6 @@ bool PlainConfig::FleetProvisioning::Validate() const | |||
| return false; | |||
| } | |||
|
|
|||
| if (csrFile.has_value() && !csrFile->empty()) | |||
There was a problem hiding this comment.
Why is this part removed?
| @@ -1239,24 +1216,6 @@ bool PlainConfig::PubSub::Validate() const | |||
| { | |||
| return true; | |||
| } | |||
| if (!publishTopic.has_value() || publishTopic->empty()) | |||
There was a problem hiding this comment.
Also why is this part removed?
| @@ -354,10 +354,6 @@ bool PlainConfig::Validate() const | |||
| LOGM_ERROR(Config::TAG, "*** %s: Certificate is missing ***", DeviceClient::DC_FATAL_ERROR); | |||
| return false; | |||
| } | |||
| else if (!FileUtils::IsValidFilePath(cert->c_str())) | |||
There was a problem hiding this comment.
I am a little bit confused on this, don't we still need to have this if we pass in params via CLI?
| @@ -1047,22 +1040,6 @@ bool PlainConfig::FleetProvisioning::Validate() const | |||
| return false; | |||
| } | |||
|
|
|||
| if (csrFile.has_value() && !csrFile->empty()) | |||
| { | |||
| if (!FileUtils::IsValidFilePath(csrFile->c_str())) | |||
|
closing this pr because PR #288 is providing better approach solving the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Change summary
Revision diff summary
If there is more than one revision, please explain what has been changed since the last revision.
Testing
Is your change tested? If not, please justify the reason.
Please list your testing steps and test results.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.