Add support for Chainer 5.0 #491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #491 +/- ##
==========================================
+ Coverage 94.23% 94.24% +<.01%
==========================================
Files 58 58
Lines 4444 4445 +1
==========================================
+ Hits 4188 4189 +1
Misses 256 256
Continue to review full report at Codecov.
|
laurenyu
suggested changes
Nov 16, 2018
Contributor
laurenyu
left a comment
laurenyu
left a comment
There was a problem hiding this comment.
talked offline - needs to make sure warnings and docs are updated appropriately
laurenyu
reviewed
Nov 16, 2018
src/sagemaker/chainer/README.rst
Outdated
| +-----------------------------+-------------+-------------+-------------+ | ||
| | chainermn | 1.2.0 | 1.3.0 | N/A | | ||
| +-----------------------------+-------------+-------------+-------------+ | ||
| | CUDA (GPU image only) | 9.0 | 9.0 | 9.0 | |
Contributor
There was a problem hiding this comment.
nit: you have extra leading spaces in some of these cells
src/sagemaker/chainer/README.rst
Outdated
| The Docker images extend Ubuntu 16.04. | ||
|
|
||
| You can select version of Chainer by passing a framework_version keyword arg to the Chainer Estimator constructor. | ||
| You must select a version of Chainer by passing a framework_version keyword arg to the Chainer Estimator constructor. |
Contributor
There was a problem hiding this comment.
double backticks around framework_version
laurenyu
previously approved these changes
Nov 16, 2018
| minor version, which will cause your training script to be run on the latest supported patch version of that minor | ||
| version. | ||
| You must select a version of Chainer by passing a ``framework_version`` keyword arg to the Chainer Estimator | ||
| constructor. Currently supported versions are listed in the above table. You can also set framework_version to only |
Contributor
There was a problem hiding this comment.
nit: add backticks around framework_version
laurenyu
approved these changes
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.