Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add awslc-fips and openssl-1.0.2-fips to valgrind #4912

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

boquan-fang
Copy link
Contributor

@boquan-fang boquan-fang commented Nov 19, 2024

Description of changes:

Compared Libcryptos that are used in buildspec_omnibus.yml and buildspec_valgrind.yml, I found out that FIPS libcryptos for awslc-fips and openssl-1.0.2-fips are missing in buildspec_valgrind.yml. This PR addresses that problem and add checks for those two Libcryptos.

Add S2N_LIBCRYPTO = awslc-fips and openssl-1.0.2-fips to buildspec_valgrind.yml. Hence, buildspec_valgrind.yml will have the same libcrypto coverage as the one in buildspec_omnibus.yml.

Call-outs:

  • An individual Valgrind check has been fully integrated into the github CI and release process CI. See PR#4851 and PR#4776. So, we should remove relevant parts of Valgrind (which is everything about Valgrind after this PR is merged) in buildspec_omnibus.yml and buildspec_generalbatch.yml. This should be followed up by future PRs.

Testing:

Tests for success:

Tests for intentionally leaking memory:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

* Add two libcryptos to Valgrind checks
@WesleyRosenblum
Copy link
Contributor

nit: Resolved issues: in the PR template is intended for referencing GitHub issues. If there isn't an actual issue, you can remove this section or say "none"

@boquan-fang boquan-fang merged commit 9877437 into aws:main Nov 22, 2024
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants