ci: add awslc-fips and openssl-1.0.2-fips to valgrind #4912
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Compared Libcryptos that are used in
buildspec_omnibus.yml
andbuildspec_valgrind.yml
, I found out that FIPS libcryptos forawslc-fips
andopenssl-1.0.2-fips
are missing inbuildspec_valgrind.yml
. This PR addresses that problem and add checks for those two Libcryptos.Add
S2N_LIBCRYPTO
=awslc-fips
andopenssl-1.0.2-fips
tobuildspec_valgrind.yml
. Hence,buildspec_valgrind.yml
will have the same libcrypto coverage as the one inbuildspec_omnibus.yml
.Call-outs:
buildspec_omnibus.yml
andbuildspec_generalbatch.yml
. This should be followed up by future PRs.Testing:
Tests for success:
Valgrind Codebuild Job
.Tests for intentionally leaking memory:
DEFER_CLEANUP
for as2n_external_psk_new()
here:s2n_early_data_test.c
intentionally leaks memory.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.