-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Adding CTest memcheck to CodeBuild #4776
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* create a buildspec file which contains ctest memcheck command
* append options for both regular and pedantic valgrind check above ASAN check
* set up valgrind options * set up valgrind ci codebuild check
jmayclin
reviewed
Sep 17, 2024
* add comments to `CMakeLists.txt` to explain pedantic valgrind check logic * change variable names to be concise * use `VALGRIND_DEFAULT` to define `VALGRIND_PEDANTIC` * reformat the CTest memecheck command to make it more readable * add explanations and necessary comments to `valgrind.suppressions`
* reformat `valgrind.suppressions` comments to make them more concise * move set Valgrind variable up. The next PR will change the location of set MEMORYCHECK_COMMAND_OPTIONS
* paste tracking issue's link to the comment
* relocate `include(CTest)` location to above unit testing sections
* explicitly enable `BUILD_TESTING` options in `CMakeLists.txt` * relocate `MEMORYCHECK_COMMAND_OPTIONS` to the testing sections above ASAN
* remove the comments above `include(CTest)` * update the message to set `BUILD_TESTING=ON`
jmayclin
reviewed
Sep 18, 2024
* refactor some comments in `CMakeLists.txt` * change suppressions names for valgrind and delete some comments
* relocate `include(CTest)` to the end of unit tests set up
* refactor formats
* add one wildcard to suppress backtrace memory defects for ubuntu22 and 24 platforms
* adjust valgrind suppressions * adjust comments format
lrstewart
reviewed
Sep 24, 2024
boquan-fang
force-pushed
the
memcheck-ci
branch
from
September 27, 2024 23:13
48cafb2
to
1eea9aa
Compare
boquan-fang
force-pushed
the
memcheck-ci
branch
from
September 27, 2024 23:14
1eea9aa
to
e7ab1ff
Compare
Explanation for "cannot find memory tester output file:" in CTest memcheck:Problem StatementCTest memcheck by default hide memory test output to a Study the source code:CTest memcheck by default add Ways that I tried to display memory errors in terminal
|
jmayclin
reviewed
Sep 30, 2024
jmayclin
approved these changes
Sep 30, 2024
lrstewart
reviewed
Oct 1, 2024
* modify valgrind suppression comments for backtrace.
* make suppression comments more precise
lrstewart
reviewed
Oct 1, 2024
Co-authored-by: Lindsay Stewart <[email protected]>
lrstewart
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Create another buildspec file for CTest memcheck. Following previous tickets instructions #3758 and PR#4369.
Description of changes:
openssl-1-1-1
.buildspec_valgrind.yml
.Call-outs:
--log-fd=2
option. I could not find another approach. Please see this comment for my reasoning.backtrace
function leaks a static amount of memory when it is first loaded, so it is safe to suppress. Read this explanation for further details.Testing:
Valgrind
and use this PR as source. The CodeBuild job is successfully.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.