-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: some open AF_UNIX sockets in forked child processes #4834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boquan-fang
force-pushed
the
open-fds-fork-child
branch
from
October 9, 2024 22:16
d305f6f
to
b98e91e
Compare
boquan-fang
force-pushed
the
open-fds-fork-child
branch
2 times, most recently
from
October 9, 2024 22:36
cc419cb
to
426bf04
Compare
boquan-fang
force-pushed
the
open-fds-fork-child
branch
from
October 9, 2024 22:40
426bf04
to
302aa86
Compare
goatgoose
approved these changes
Oct 10, 2024
lrstewart
reviewed
Oct 10, 2024
boquan-fang
force-pushed
the
open-fds-fork-child
branch
from
October 10, 2024 20:12
290ea83
to
d71dc74
Compare
* move `s2n_io_pair_close_one_end` before `s2n_cleanup`
boquan-fang
force-pushed
the
open-fds-fork-child
branch
from
October 10, 2024 20:19
d71dc74
to
b2a0879
Compare
lrstewart
reviewed
Oct 10, 2024
* move s2n_io_pair_close_one_end to be right above s2n_cleanup so that it doesn't cause the test to fail
maddeleine
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Partially solve #4005
Description of changes:
Call-outs:
Testing:
--track-fds=yes
to CTest memcheck and direct all Valgrind output toMemoryTester.log
files.AF_UNIX
.AF_UNIX
sockets in tests that are fixed are gone../codebuild/bin/test_exec_leak.sh
.s2n-tls/codebuild/bin/test_exec_leak.sh
Lines 82 to 97 in 6bb195c
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.