-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix opened AF_UNIX sockets that didn't call s2n_io_pair_close #4833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 9, 2024
boquan-fang
force-pushed
the
open-fds-no-close
branch
from
October 9, 2024 22:18
9ddb3be
to
3554aca
Compare
boquan-fang
force-pushed
the
open-fds-no-close
branch
from
October 9, 2024 22:35
3554aca
to
d3bed35
Compare
goatgoose
reviewed
Oct 10, 2024
boquan-fang
changed the title
fix: fix opened AF_UNIX sockets that are didn't call s2n_io_pair_close
fix: fix opened AF_UNIX sockets that didn't call s2n_io_pair_close
Oct 10, 2024
lrstewart
reviewed
Oct 10, 2024
boquan-fang
force-pushed
the
open-fds-no-close
branch
4 times, most recently
from
October 10, 2024 20:03
d2356b2
to
30c54be
Compare
boquan-fang
force-pushed
the
open-fds-no-close
branch
from
October 10, 2024 20:16
30c54be
to
b9e61fe
Compare
goatgoose
reviewed
Oct 10, 2024
lrstewart
reviewed
Oct 10, 2024
boquan-fang
force-pushed
the
open-fds-no-close
branch
from
October 11, 2024 00:18
333d34f
to
b9e61fe
Compare
lrstewart
reviewed
Oct 11, 2024
boquan-fang
force-pushed
the
open-fds-no-close
branch
from
October 11, 2024 21:47
891da38
to
8493d8c
Compare
* fix all problems and move s2n_connection_test_utilc.c and s2n_testlib.h changes to another PR
boquan-fang
force-pushed
the
open-fds-no-close
branch
from
October 11, 2024 21:51
8493d8c
to
c5b3475
Compare
goatgoose
approved these changes
Oct 16, 2024
maddeleine
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Partially solve #4005
Description of changes:
Call-outs:
Testing:
--track-fds=yes
to CTest memcheck and direct all Valgrind output toMemoryTester.log
files.AF_UNIX
.AF_UNIX
sockets in tests that are fixed are gone../codebuild/bin/test_exec_leak.sh
.s2n-tls/codebuild/bin/test_exec_leak.sh
Lines 82 to 97 in 6bb195c
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.