Fix s2n_shutdown + failed recv bug #4350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddeleine
approved these changes
Jan 18, 2024
Co-authored-by: maddeleine <[email protected]>
camshaft
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Related to #3976
Description of changes:
I'm working on cleaning up the flaky blinding tests in the tokio bindings. They were mysteriously not failing with the correct expected error. I discovered that because the bindings tests trigger blinding by receiving a malformed record, they were causing s2n_shutdown to try to read with a dirty header_in stuffer. That led to some very strange errors.
I've fixed the problem by cleaning up header_in/in before every read instead of after every read. That's what s2n_shutdown used to do, and I'm not sure why I changed it :(
Testing:
Added a C unit test, fixed the original failing s2n-tls-tokio test
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.