Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flaky test: handshake_error_with_blinding, rust bindings #3976

Closed
jmayclin opened this issue May 2, 2023 · 3 comments · Fixed by #4356
Closed

flaky test: handshake_error_with_blinding, rust bindings #3976

jmayclin opened this issue May 2, 2023 · 3 comments · Fixed by #4356

Comments

@jmayclin
Copy link
Contributor

jmayclin commented May 2, 2023

Problem:

I've observed this test failing multiple times.


test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/handshake.rs (target/debug/deps/handshake-13a4925c995491eb)

Error: Elapsed(())
running 7 tests
test handshake_error ... ok
test handshake_basic ... ok
test handshake_error_with_blinding ... FAILED
test handshake_with_connection_config ... ok
test io_stream_access ... ok
error: test failed, to rerun pass '-p s2n-tls-tokio --test handshake'
test handshake_with_connection_config_with_pool ... ok
test handshake_with_pool_multithread ... ok

failures:

---- handshake_error_with_blinding stdout ----
thread 'handshake_error_with_blinding' panicked at 'assertion failed: `(left == right)`
  left: `1`,
 right: `0`: the test returned a termination value with a non-zero status code (1) which indicates a failure', /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/test/src/lib.rs:184:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

occurrence

Solution:

Unknown

Requirements / Acceptance Criteria:

The test should not fail

Out of scope:

@jmayclin jmayclin changed the title flaky test: b flaky test: handshake_error_with_blinding, rust bindings May 2, 2023
@jmayclin
Copy link
Contributor Author

#3417 Adds some interesting historical context.

@maddeleine
Copy link
Contributor

Just a note, I saw this fail recently, so this is still a problem.

@maddeleine
Copy link
Contributor

Another note: the specific reason why this test fails is that the blinding occasionally goes past 30 seconds. I don't know why that happens, I suspect it has something to do with the way that tokio will automatically advance the clock when an async sleep is called, given that there's no other async work to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants