Build option to print file basename only (s2n_strerror_debug) #4211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a build flag to allow having debug output print basename of the file instead of absolute path.
ma-ilsi
changed the title
|
I think I prefer #4209 instead of a build-time option. Only supporting newer compilers for this functionality is less than ideal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Resolves #4208.
Description of changes:
Changes to the build scripts and
error/s2n_errno.hintroduce the addition of a build option which enables debug output to only print the file basename instead of the absolute path.No changes have been made to the client-facing API.
Call-outs:
__FILE_NAME__macro is available inclangsince 9.0.0, see the release note. Currentclangversion is 17.0.1.__FILE_NAME__macro is available ingccsince GCC 12, see comments 10 & 13. Currentgccversion is 13.2.The
error/s2n_errno.hchecks if__FILE_NAME__macro is defined, otherwise defaults to behaviour of full path output.Testing:
Local build and tests on Ubuntu succeed. All current tests pass with the
S2N_DEBUG_OUTPUT_FILENAMEflag both ON and OFF. No new tests added by me for this flag, though.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.