feat: add s2n_strerror_source API #4209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
error-file-line
branch
3 times, most recently
from
b511402 to
7bd50d5
Compare
camshaft
force-pushed
the
error-file-line
branch
3 times, most recently
from
87b6250 to
622fc61
Compare
goatgoose
reviewed
Sep 21, 2023
camshaft
changed the title
camshaft
force-pushed
the
error-file-line
branch
from
622fc61 to
3895794
Compare
goatgoose
approved these changes
Sep 21, 2023
Co-authored-by: Sam Clark <[email protected]>
lrstewart
reviewed
Sep 21, 2023
There was a problem hiding this comment.
Not really related to your PR, but should this even be committed?
There was a problem hiding this comment.
Probably not...? No idea 😄
lrstewart
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Resolves #4208
Description of changes:
As noted in the issue, customers currently lack a good solution to get a short error message that just contains the filename and line number. This PR adds such an API.
Call-outs:
Luckily, this change doesn't actually increase the size of the final artifact at all. This is due to the fact that we use the same static string produce by
_S2N_DEBUG_STR, just indexed into where the filename is. You can see that in an example godbolt: https://godbolt.org/z/b5rdY8rnn.Testing:
I added a simple unit test showing that the output is just the file name.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.