X509 asn1 refactor #4011
Merged
X509 asn1 refactor #4011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the rust bindings generation complains that the expansion of the macro results in an integer overflow
goatgoose
reviewed
May 22, 2023
Co-authored-by: Sam Clark <[email protected]>
maddeleine
reviewed
May 23, 2023
Add RFC quote for thisUpdate and nextUpdate fields, and add additional clarification about the maximum timestamp thing.
goatgoose
reviewed
May 23, 2023
goatgoose
approved these changes
May 23, 2023
maddeleine
approved these changes
May 23, 2023
dougch
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
#3948
Description of changes:
Refactor x509 OCSP functionality to use ASN1 time comparison instead of our custom ASN1 parser. This removes the final place in S2N where a future date needs to be represented by a
time_t. This PR will bring 32 bit support up toCall-outs:
The ASN1 time diff is rather hairy, which is why I previously added more tests: #3970
Testing:
Additional unit tests were added in #3970 to give more coverage, so all CI passing should be sufficient.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.