Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failing unit tests on 32 bit build #3948

Closed
jmayclin opened this issue Apr 19, 2023 · 0 comments
Closed

failing unit tests on 32 bit build #3948

jmayclin opened this issue Apr 19, 2023 · 0 comments

Comments

@jmayclin
Copy link
Contributor

Problem:

4 unit tests are failing on 32 bit builds

        set(CTEST_CUSTOM_TESTS_IGNORE
            s2n_cert_status_extension_test
            s2n_self_talk_nonblocking_test
            s2n_session_ticket_test
            s2n_x509_validator_test
        )

We need to fix these unit tests. After they are fixed, the above section should be removed from our CMakeLists.txt.

Solution:

Some of the issues are related to OCSP ASN1 Time parsing issues for dates past 2038. Libcrypto provides functions to directly compare those times (which work on 32 bit platforms) so we should prefer to use those.

The the other tests fail because we set the current system time to a date past 2038 as part of our unit tests. We expect that s2n-tls 32 bit support will be provided with the caveat that "system clock must not represent a date past 2038", so these aren't a huge problem, but we will need to refactor the units tests such that they pass.

Requirements / Acceptance Criteria:

All unit tests past.

Out of scope:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants