You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We need to fix these unit tests. After they are fixed, the above section should be removed from our CMakeLists.txt.
Solution:
Some of the issues are related to OCSP ASN1 Time parsing issues for dates past 2038. Libcrypto provides functions to directly compare those times (which work on 32 bit platforms) so we should prefer to use those.
The the other tests fail because we set the current system time to a date past 2038 as part of our unit tests. We expect that s2n-tls 32 bit support will be provided with the caveat that "system clock must not represent a date past 2038", so these aren't a huge problem, but we will need to refactor the units tests such that they pass.
Requirements / Acceptance Criteria:
All unit tests past.
Out of scope:
The text was updated successfully, but these errors were encountered:
Problem:
4 unit tests are failing on 32 bit builds
We need to fix these unit tests. After they are fixed, the above section should be removed from our
CMakeLists.txt
.Solution:
Some of the issues are related to OCSP ASN1 Time parsing issues for dates past 2038. Libcrypto provides functions to directly compare those times (which work on 32 bit platforms) so we should prefer to use those.
The the other tests fail because we set the current system time to a date past 2038 as part of our unit tests. We expect that s2n-tls 32 bit support will be provided with the caveat that "system clock must not represent a date past 2038", so these aren't a huge problem, but we will need to refactor the units tests such that they pass.
Requirements / Acceptance Criteria:
All unit tests past.
Out of scope:
The text was updated successfully, but these errors were encountered: