Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expected negotiated version in client auth downgrade test #3951

Merged
merged 4 commits into from
Apr 21, 2023
Merged

Fix expected negotiated version in client auth downgrade test #3951

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ece7aa3
Fix expected negotiated version in client auth downgrade test
goatgoose Apr 20, 2023
5d27868
better RSA-PSS libcrypto check
goatgoose Apr 21, 2023
469c38c
pr feedback
goatgoose Apr 21, 2023
3f941bb
Merge branch 'main' into fix-downgrade-test
goatgoose Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion tests/integrationv2/test_client_authentication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,16 @@ def test_tls_12_client_auth_downgrade(managed_process):

# A s2n server built with OpenSSL1.0.2 and enabling client auth will downgrade the protocol to TLS1.2.
# The downgrade occurs because openssl-1.0.2 doesn't support RSA-PSS signature scheme.
if "openssl-1.0.2" in get_flag(S2N_PROVIDER_VERSION):
#
# TLS 1.3 is disabled when s2n-tls is built with libressl and boringssl, so TLS 1.2 will be negotiated
# with these libcryptos as well. https://github.com/aws/s2n-tls/issues/3250
if any([
libcrypto_str in get_flag(S2N_PROVIDER_VERSION) for libcrypto_str in [
"openssl-1.0.2",
"libressl",
"boringssl"
]
]):
expected_protocol_version = Protocols.TLS12.value
else:
expected_protocol_version = Protocols.TLS13.value
Expand Down