Fix expected negotiated version in client auth downgrade test #3951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditishri18
approved these changes
Apr 20, 2023
lrstewart
reviewed
Apr 21, 2023
goatgoose
force-pushed
the
fix-downgrade-test
branch
from
8b91df5 to
5d27868
Compare
lrstewart
reviewed
Apr 21, 2023
maddeleine
approved these changes
Apr 21, 2023
lrstewart
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The TLS 1.2 client auth downgrade test, added in #3939, failed when testing with s2n-tls linked to LibreSSL and BoringSSL. This is because the test expects TLS 1.3 to be negotiated with LibreSSL and BoringSSL, even though TLS 1.3 is currently disabled with these libcryptos (see #3250).
This PR updates the TLS 1.2 client auth downgrade test to expect a TLS 1.2 handshake when linked to LibreSSL and BoringSSL.
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.