Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: upgrade checkout action to v3 #3761

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Conversation

jmayclin
Copy link
Contributor

A CI run failed with the following message:"Please update the following actions to use Node.js 16: actions/checkout@v2". We can accomplish the node upgrade by just moving to the newest version of the action.

https://github.com/aws/s2n-tls/actions/runs/3942181338

Description of changes:

find and replace actions/checkout@v2 to actions/checkout@v3

Call-outs:

https://stackoverflow.com/questions/73473617/what-is-the-difference-between-github-actions-checkoutv3-and-v2

I don't expect any differences in behavior besides the node version bump.

Testing:

No unit testing, as long as it passes CI we should be good to go.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

A CI run failed with the following message:"Please update the following
actions to use Node.js 16: actions/checkout@v2". We can accomplish the
node upgrade by just moving to the newest version of the action.
@jmayclin jmayclin requested review from dougch and maddeleine January 17, 2023 19:51
@github-actions github-actions bot added the s2n-core team label Jan 17, 2023
Copy link
Contributor

@dougch dougch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, past time for dependabot

@jmayclin jmayclin changed the title ci: upgrade checkout action ci: upgrade checkout action to v3 Jan 17, 2023
@jmayclin jmayclin enabled auto-merge (squash) January 17, 2023 20:01
@jmayclin jmayclin merged commit ed05306 into aws:main Jan 17, 2023
@jmayclin
Copy link
Contributor Author

created an issue to track the build-dashboard CI action failure that happens after merge.

@jmayclin jmayclin deleted the checkout-upgrade branch December 22, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants