Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Dashboard Errors #3763

Open
jmayclin opened this issue Jan 17, 2023 · 1 comment
Open

Build Dashboard Errors #3763

jmayclin opened this issue Jan 17, 2023 · 1 comment
Labels

Comments

@jmayclin
Copy link
Contributor

jmayclin commented Jan 17, 2023

Problem:

Problem 1 - dead dependencies
Our build dashboard has a transitive dependency on node 12 through ethomson/issue-dashboard. Node 12 is now deprecated, and is causing CI runs of the build dashboard action to fail. (just a warning, not an error)[but we should still fix it] An example is here

Problem 2 - flaky behavior
I'm not certain how this was caused, but the tree seems to be in an inconsistent state, which caused a failure when trying to push changes to the branch: here It seems like this might be related to a race condition between the doxygen update action and the build dashboard action.

This problem is irritating because it ends up marking closed PRs as "bad" PR's since they fail the build-dashboard ci, but the CI only runs after the action is closed/merged, so there isn't an easy way to prevent this.

Solution:

I generally don't want any actions that run after I merge the PR, that way I can be 100% sure that the merge is good and will be documented as such.

Option 1 (preferred): nuke this entire action, the issue-dashboard repo appears to be dead, find some other alternative (and preferably don't run it on PR closes)

Option 2:

  • git pull on the gh-page branch actions to prevent the inconsistent state.
  • shift the action to a schedule expression to de-couple it from PR's. It could run every day at midnight or something like that.

Requirements / Acceptance Criteria:

No action failures, and preferably a replacement

@dougch
Copy link
Contributor

dougch commented Jan 17, 2023

Both the dashboard and doxygen actions run on PR close, which seems to be causing a race condition, e.g. https://github.com/aws/s2n-tls/actions/runs/3943198717/jobs/6747759539. Maybe it's not a safe to assume only one update to gh-pages is in-flight at any time?

jmayclin added a commit to jmayclin/s2n-tls that referenced this issue Jan 17, 2023
issue here: aws#3763. This action does
not run, since the issue-dashboard relies on node 12, which is
deprecated and no longer runs in GH actions.

This commit entirely removes the workflow. Once the team has a solution
this commit will likely be reverted and the action added back in, but
rather than just temporarily disabling it I think it's cleaner to just
entirely remove it while it's broken.
jmayclin added a commit that referenced this issue Jan 25, 2023
issue here: #3763. This action often 
fails due to a race condition between it and the documentation generation
action.

This commit partly sidesteps the issue by scheduling this action separately
from the documentation action. Further actions are tracked in the github
issue.
@toidiu toidiu added the s2n-core team label Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants