fix: make toolchain failing due to deletion of asciicheck

[sumukha-radhakrishna]

Fixes: Failing CI and make toolchain

• Upgrades golangci-lint
• upgrades the config
• Ran presubmit to auto lints/corrects based on golangci-lint v2

Currently make toolchain fails with

/Users/rsumukha/go/pkg/mod/github.com/golangci/[email protected]/pkg/golinters/asciicheck/asciicheck.go:4:2: reading github.com/tdakkota/asciicheck/go.mod at revision v0.4.1: git ls-remote -q origin in /Users/rsumukha/go/pkg/mod/cache/vcs/e91413ff76cb95901df8e2d834855d07c617befa58b5014bc6cd6fd1148034dd: exit status 128:
	remote: Repository not found.
	fatal: repository 'https://github.com/tdakkota/asciicheck/' not found
make: *** [toolchain] Error 1

asciicheck is a dependency of golangci-lint, asciicheck has been deleted 🫤 https://github.com/tdakkota/asciicheck
CI will start failing once the cached package expire.

golangci started maintaining a forked version of asciicheck - https://github.com/golangci/asciicheck

They have updated their go.mod to use the forked version but havent released yet. We will use main until they release.

SInce we need to upgrade to v2 of golangci-lint, we need to migrate the config that changes/corrects based off v2.

How was this change tested?

make toolchain succeeds.

[netlify]

✅ Deploy Preview for karpenter-docs-prod canceled.

Name	Link
🔨 Latest commit	2e22535
🔍 Latest deploy log	https://app.netlify.com/projects/karpenter-docs-prod/deploys/68bb278a461acf0008a0e462

[github-actions]

Preview deployment ready!

Preview URL: https://pr-8453.d18coufmbnnaag.amplifyapp.com

Built from commit 2e225355483da6d4bcb5d83b1ec2e74011fb369f

[jonathan-innis]

LGTM 🚀

[coveralls]

Pull Request Test Coverage Report for Build 17501001861

Details

• 13 of 24 (54.17%) changed or added relevant lines in 12 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.1%) to 67.228%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
test/pkg/environment/aws/metrics.go	0	1	0.0%
test/pkg/environment/aws/setup.go	0	1	0.0%
test/pkg/debug/node.go	0	2	0.0%
test/pkg/debug/nodeclaim.go	0	2	0.0%
test/pkg/debug/pod.go	0	2	0.0%
test/pkg/environment/aws/expectations.go	0	3	0.0%

Totals
Change from base Build 17500710494:	0.1%
Covered Lines:	7629
Relevant Lines:	11348

---

💛 - Coveralls