Skip to content

Conversation

@sugmanue
Copy link
Contributor

@sugmanue sugmanue commented Oct 5, 2023

Motivation and Context

This change exposes the map of AuthSchemes configured in the client using the SdkServiceClientConfiguration class.

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@sugmanue sugmanue requested a review from a team as a code owner October 5, 2023 15:01
@sugmanue sugmanue force-pushed the sugmanue/sra-ia-add-auth-scheme-to-config branch from 99af209 to be4d511 Compare October 6, 2023 16:41
@sugmanue sugmanue force-pushed the sugmanue/sra-ia-add-auth-scheme-to-config branch from be4d511 to 0f25a1e Compare October 6, 2023 16:47
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 9 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 478 Code Smells

85.0% 85.0% Coverage
4.2% 4.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sugmanue sugmanue merged commit 06fdecf into feature/master/sra-identity-auth Oct 6, 2023
@sugmanue sugmanue deleted the sugmanue/sra-ia-add-auth-scheme-to-config branch October 6, 2023 19:16
/**
* @return The configured map of auth schemes.
*/
public Map<String, AuthScheme<?>> authSchemes() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may be misremembering, but weren't we saying this should be on the SdkServiceClientConfiguration since it is generic and not aws-specific?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I opened #4580 to fix this and other issues. Thanks!

aws-sdk-java-automation added a commit that referenced this pull request Dec 3, 2025
…d531f2640

Pull request: release <- staging/c3320ee5-7f42-44bb-838f-ab4d531f2640
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants