-
Notifications
You must be signed in to change notification settings - Fork 1k
Module changes for Identity & Auth #3764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gosar
merged 5 commits into
feature/master/sra-identity-auth
from
gosar/sra-ia-module-changes
Feb 17, 2023
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7cb9503
Add new Identity and Authentication modules
gosar c16712a
Update Identity & Auth module dependencies
gosar 9881e49
Add temporary Placeholder class
gosar 8a2629f
Temporarily not fail maven-dependency-plugin
gosar 45b2f67
Removed some answered TODOs
gosar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- | ||
| ~ Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| ~ | ||
| ~ Licensed under the Apache License, Version 2.0 (the "License"). | ||
| ~ You may not use this file except in compliance with the License. | ||
| ~ A copy of the License is located at | ||
| ~ | ||
| ~ http://aws.amazon.com/apache2.0 | ||
| ~ | ||
| ~ or in the "license" file accompanying this file. This file is distributed | ||
| ~ on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
| ~ express or implied. See the License for the specific language governing | ||
| ~ permissions and limitations under the License. | ||
| --> | ||
|
|
||
| <project xmlns="http://maven.apache.org/POM/4.0.0" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <parent> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>core</artifactId> | ||
| <version>2.20.2-SNAPSHOT</version> | ||
| </parent> | ||
|
|
||
| <artifactId>http-auth-aws-crt</artifactId> | ||
| <name>AWS Java SDK :: HTTP Auth AWS CRT</name> | ||
| <description> | ||
| The AWS SDK for Java - Auth module holds the AWS Common Runtime based implementations that are used for | ||
| authentication with HTTP services | ||
| </description> | ||
| <!-- TODO: this is not present in all pom.xml files. Is there a reason, or just a miss --> | ||
| <url>https://aws.amazon.com/sdkforjava</url> | ||
|
|
||
| <dependencies> | ||
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>http-auth-spi</artifactId> | ||
| <version>${awsjavasdk.version}</version> | ||
| </dependency> | ||
| </dependencies> | ||
| </project> | ||
23 changes: 23 additions & 0 deletions
23
...http-auth-aws-crt/src/main/java/software/amazon/awssdk/http/auth/aws/crt/Placeholder.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| /* | ||
| * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"). | ||
| * You may not use this file except in compliance with the License. | ||
| * A copy of the License is located at | ||
| * | ||
| * http://aws.amazon.com/apache2.0 | ||
| * | ||
| * or in the "license" file accompanying this file. This file is distributed | ||
| * on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
| * express or implied. See the License for the specific language governing | ||
| * permissions and limitations under the License. | ||
| */ | ||
|
|
||
| package software.amazon.awssdk.http.auth.aws.crt; | ||
|
|
||
| import software.amazon.awssdk.annotations.SdkInternalApi; | ||
|
|
||
| // TODO: Remove when where is actual code in this module | ||
| @SdkInternalApi | ||
| public interface Placeholder { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- | ||
| ~ Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| ~ | ||
| ~ Licensed under the Apache License, Version 2.0 (the "License"). | ||
| ~ You may not use this file except in compliance with the License. | ||
| ~ A copy of the License is located at | ||
| ~ | ||
| ~ http://aws.amazon.com/apache2.0 | ||
| ~ | ||
| ~ or in the "license" file accompanying this file. This file is distributed | ||
| ~ on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
| ~ express or implied. See the License for the specific language governing | ||
| ~ permissions and limitations under the License. | ||
| --> | ||
|
|
||
| <project xmlns="http://maven.apache.org/POM/4.0.0" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <parent> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>core</artifactId> | ||
| <version>2.20.2-SNAPSHOT</version> | ||
| </parent> | ||
|
|
||
| <artifactId>http-auth-aws</artifactId> | ||
| <name>AWS Java SDK :: HTTP Auth AWS</name> | ||
| <description> | ||
| The AWS SDK for Java - Auth module holds the classes that are used for authentication with AWS services | ||
| </description> | ||
| <!-- TODO: this is not present in all pom.xml files. Is there a reason, or just a miss --> | ||
| <url>https://aws.amazon.com/sdkforjava</url> | ||
|
|
||
| <dependencies> | ||
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>http-auth-spi</artifactId> | ||
| <version>${awsjavasdk.version}</version> | ||
| </dependency> | ||
| </dependencies> | ||
| </project> |
23 changes: 23 additions & 0 deletions
23
core/http-auth-aws/src/main/java/software/amazon/awssdk/http/auth/aws/Placeholder.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| /* | ||
| * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"). | ||
| * You may not use this file except in compliance with the License. | ||
| * A copy of the License is located at | ||
| * | ||
| * http://aws.amazon.com/apache2.0 | ||
| * | ||
| * or in the "license" file accompanying this file. This file is distributed | ||
| * on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
| * express or implied. See the License for the specific language governing | ||
| * permissions and limitations under the License. | ||
| */ | ||
|
|
||
| package software.amazon.awssdk.http.auth.aws; | ||
|
|
||
| import software.amazon.awssdk.annotations.SdkInternalApi; | ||
|
|
||
| // TODO: Remove when where is actual code in this module | ||
| @SdkInternalApi | ||
| public interface Placeholder { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- | ||
| ~ Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| ~ | ||
| ~ Licensed under the Apache License, Version 2.0 (the "License"). | ||
| ~ You may not use this file except in compliance with the License. | ||
| ~ A copy of the License is located at | ||
| ~ | ||
| ~ http://aws.amazon.com/apache2.0 | ||
| ~ | ||
| ~ or in the "license" file accompanying this file. This file is distributed | ||
| ~ on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
| ~ express or implied. See the License for the specific language governing | ||
| ~ permissions and limitations under the License. | ||
| --> | ||
|
|
||
| <project xmlns="http://maven.apache.org/POM/4.0.0" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <parent> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>core</artifactId> | ||
| <version>2.20.2-SNAPSHOT</version> | ||
| </parent> | ||
|
|
||
| <artifactId>http-auth-event-stream</artifactId> | ||
| <name>AWS Java SDK :: HTTP Auth Event Stream</name> | ||
| <description> | ||
| The AWS SDK for Java - HTTP Auth Even Stream module holds the classes that are used for authentication of | ||
| event streams in HTTP services | ||
| </description> | ||
| <!-- TODO: this is not present in all pom.xml files. Is there a reason, or just a miss --> | ||
| <url>https://aws.amazon.com/sdkforjava</url> | ||
|
|
||
| <dependencies> | ||
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>http-auth-spi</artifactId> | ||
| <version>${awsjavasdk.version}</version> | ||
| </dependency> | ||
| </dependencies> | ||
| </project> |
23 changes: 23 additions & 0 deletions
23
...-event-stream/src/main/java/software/amazon/awssdk/http/auth/eventstream/Placeholder.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| /* | ||
| * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"). | ||
| * You may not use this file except in compliance with the License. | ||
| * A copy of the License is located at | ||
| * | ||
| * http://aws.amazon.com/apache2.0 | ||
| * | ||
| * or in the "license" file accompanying this file. This file is distributed | ||
| * on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
| * express or implied. See the License for the specific language governing | ||
| * permissions and limitations under the License. | ||
| */ | ||
|
|
||
| package software.amazon.awssdk.http.auth.eventstream; | ||
|
|
||
| import software.amazon.awssdk.annotations.SdkInternalApi; | ||
|
|
||
| // TODO: Remove when where is actual code in this module | ||
| @SdkInternalApi | ||
| public interface Placeholder { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- | ||
| ~ Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| ~ | ||
| ~ Licensed under the Apache License, Version 2.0 (the "License"). | ||
| ~ You may not use this file except in compliance with the License. | ||
| ~ A copy of the License is located at | ||
| ~ | ||
| ~ http://aws.amazon.com/apache2.0 | ||
| ~ | ||
| ~ or in the "license" file accompanying this file. This file is distributed | ||
| ~ on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
| ~ express or implied. See the License for the specific language governing | ||
| ~ permissions and limitations under the License. | ||
| --> | ||
|
|
||
| <project xmlns="http://maven.apache.org/POM/4.0.0" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <parent> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>core</artifactId> | ||
| <version>2.20.2-SNAPSHOT</version> | ||
| </parent> | ||
|
|
||
| <artifactId>http-auth-spi</artifactId> | ||
| <name>AWS Java SDK :: HTTP Auth SPI</name> | ||
| <description> | ||
| The AWS SDK for Java - HTTP Auth SPI module contains the interfaces for authentication that are used by other | ||
| modules in the library. | ||
| </description> | ||
| <!-- TODO: this is not present in all pom.xml files. Is there a reason, or just a miss --> | ||
| <url>https://aws.amazon.com/sdkforjava</url> | ||
|
|
||
| <dependencies> | ||
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>identity-spi</artifactId> | ||
| <version>${awsjavasdk.version}</version> | ||
| </dependency> | ||
| </dependencies> | ||
| </project> |
23 changes: 23 additions & 0 deletions
23
core/http-auth-spi/src/main/java/software/amazon/awssdk/http/auth/spi/Placeholder.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| /* | ||
| * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"). | ||
| * You may not use this file except in compliance with the License. | ||
| * A copy of the License is located at | ||
| * | ||
| * http://aws.amazon.com/apache2.0 | ||
| * | ||
| * or in the "license" file accompanying this file. This file is distributed | ||
| * on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
| * express or implied. See the License for the specific language governing | ||
| * permissions and limitations under the License. | ||
| */ | ||
|
|
||
| package software.amazon.awssdk.http.auth.spi; | ||
|
|
||
| import software.amazon.awssdk.annotations.SdkInternalApi; | ||
|
|
||
| // TODO: Remove when where is actual code in this module | ||
| @SdkInternalApi | ||
| public interface Placeholder { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- | ||
| ~ Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| ~ | ||
| ~ Licensed under the Apache License, Version 2.0 (the "License"). | ||
| ~ You may not use this file except in compliance with the License. | ||
| ~ A copy of the License is located at | ||
| ~ | ||
| ~ http://aws.amazon.com/apache2.0 | ||
| ~ | ||
| ~ or in the "license" file accompanying this file. This file is distributed | ||
| ~ on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
| ~ express or implied. See the License for the specific language governing | ||
| ~ permissions and limitations under the License. | ||
| --> | ||
|
|
||
| <project xmlns="http://maven.apache.org/POM/4.0.0" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <parent> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>core</artifactId> | ||
| <version>2.20.2-SNAPSHOT</version> | ||
| </parent> | ||
|
|
||
| <artifactId>http-auth</artifactId> | ||
| <!-- TODO: HTTP v/s Http --> | ||
| <name>AWS Java SDK :: HTTP Auth</name> | ||
| <description> | ||
| The AWS SDK for Java - HTTP Auth module holds the classes that are used for authentication with generic HTTP | ||
| services | ||
| </description> | ||
| <!-- TODO: this is not present in all pom.xml files. Is there a reason, or just a miss --> | ||
| <url>https://aws.amazon.com/sdkforjava</url> | ||
|
|
||
| <dependencies> | ||
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>http-auth-spi</artifactId> | ||
| <version>${awsjavasdk.version}</version> | ||
| </dependency> | ||
| </dependencies> | ||
| </project> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably just a miss.. Unless it's inherited from the parent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, doesn't seem to be inherited. https://github.com/aws/aws-sdk-java-v2/blob/master/http-client-spi/pom.xml doesn't have it and https://search.maven.org/artifact/software.amazon.awssdk/http-client-spi doesn't have Home page link. Compared to https://search.maven.org/artifact/software.amazon.awssdk/auth which does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed these TODOs and another one for HTTP v/s Http as we use HTTP in other modules already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must just be a miss, then!