Module changes for Identity & Auth #3764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These modules are empty for now.
So there is a jar created for the module.
Currently have setup dependencies in maven but there is not actual code dependencies across these modules. Once new code is added to the modules this will be undone.
millems
reviewed
Feb 16, 2023
core/http-auth-aws-crt/pom.xml
Outdated
Comment on lines
34
to
35
| <!-- TODO: this is not present in all pom.xml files. Is there a reason, or just a miss --> | ||
| <url>https://aws.amazon.com/sdkforjava</url> |
Contributor
There was a problem hiding this comment.
Probably just a miss.. Unless it's inherited from the parent?
Contributor
Author
There was a problem hiding this comment.
Hmm, doesn't seem to be inherited. https://github.com/aws/aws-sdk-java-v2/blob/master/http-client-spi/pom.xml doesn't have it and https://search.maven.org/artifact/software.amazon.awssdk/http-client-spi doesn't have Home page link. Compared to https://search.maven.org/artifact/software.amazon.awssdk/auth which does.
Contributor
Author
There was a problem hiding this comment.
removed these TODOs and another one for HTTP v/s Http as we use HTTP in other modules already.
Contributor
There was a problem hiding this comment.
Must just be a miss, then!
gosar
changed the base branch from
master
to
feature/master/sra-identity-auth
|
Kudos, SonarCloud Quality Gate passed! |
12 tasks
11 tasks
aws-sdk-java-automation
pushed a commit
that referenced
this pull request
Mar 24, 2025
update crt version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
As part of Smithy Reference Architecture, we are defining new Identity and Auth interfaces that will reside in new modules.
Modifications
This change adds new modules and makes existing modules will depend on these new modules for backwards-compatibility. The actual code changes will be done in separate PRs. This change preps the module changes only. To allow the build to succeed, Placeholder.java classes are added to make the module jar non-empty and also maven-dependency-plugin has been temporarily disabled.
Testing
./mvnw clean installScreenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License