chore(deps): bumping cdk from 1.78.0 to 1.83.0 #289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I deployed the all in AWS infrastructure basic app to confirm that everything is working.
Besides the CDK version bump, this includes:
usage-based-licensing.tscaused by the change in CDK fix(aws-ecs): update desired count to be optional aws-cdk#12223 . OurUsageBasedLicensingconstruct usesdesiredCountnot only forEc2Service, but also forASG. As we want these values to be the same, we won't be removing theDesiredCountsimilar to CDK, but will keep the same behavior as before, defaulting to 1. We do this, because if we don't setDesiredCountexplicitly for theService, it will use the current task number, but we won't be able to get this number for ASG from the service.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license