Skip to content

Conversation

@iamhopaul123
Copy link
Contributor


Fixes #11951. Update desiredCount to be optional in compliance with aws/containers-roadmap#493 (comment).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 24, 2020

@iamhopaul123 iamhopaul123 force-pushed the ecs/update-desired-count branch from 1af4e2e to 578e1a1 Compare December 25, 2020 00:09
@aws aws deleted a comment from aws-cdk-automation Dec 25, 2020
@iamhopaul123 iamhopaul123 force-pushed the ecs/update-desired-count branch 2 times, most recently from 036591e to 0e15a54 Compare December 28, 2020 18:18
@iamhopaul123 iamhopaul123 force-pushed the ecs/update-desired-count branch 2 times, most recently from 2ecee1a to 030be38 Compare January 3, 2021 23:45
@iamhopaul123 iamhopaul123 force-pushed the ecs/update-desired-count branch from 030be38 to e47491e Compare January 4, 2021 03:23
SoManyHs
SoManyHs previously approved these changes Jan 4, 2021
@SoManyHs SoManyHs added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Jan 4, 2021
@mergify mergify bot dismissed SoManyHs’s stale review January 4, 2021 18:42

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 814d4b7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@SoManyHs
Copy link
Contributor

SoManyHs commented Jan 4, 2021

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jan 4, 2021

Command update: success

Branch already up to date

@iamhopaul123
Copy link
Contributor Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jan 4, 2021

Command update: success

Branch has been successfully updated

@mergify
Copy link
Contributor

mergify bot commented Jan 4, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 455540b into aws:master Jan 4, 2021
flochaz pushed a commit to flochaz/aws-cdk that referenced this pull request Jan 5, 2021
----
Fixes aws#11951. Update `desiredCount` to be optional in compliance with aws/containers-roadmap#493 (comment).
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@alvyn279 alvyn279 mentioned this pull request Jan 8, 2021
64 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@aws-cdk/aws-ecs Related to Amazon Elastic Container

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(ecs): Optional DesiredCount value should be omitted in templates

3 participants