fix(logs): cannot use same Lambda for multiple SubscriptionFilters #4975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to scope the permission for calling it from CloudWatch Logs under the Lambda. However, when it was used multiple times there would be a name conflict. Instead, scope the Permission under the SubscriptionFilter. Fixes #4951.
Contributor
|
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
eladb
approved these changes
Nov 12, 2019
Contributor
|
Thank you for contributing! Your pull request is now being automatically merged. |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
is this live? because i just updated core and all modules to 1.16.3 and i still have the "InvokedByCloudWatchLogs" issue when subscribing multiple log groups to a single lambda function. |
arhea
pushed a commit
to arhea/aws-cdk
that referenced
this pull request
Nov 19, 2019
…5-eks-patterns * '4955-eks-patterns' of github.com:arhea/aws-cdk: feat(cli): adding new option to `cdk deploy` to indicate whether ChangeSet should be executed (aws#4852) chore: move semantic.yaml to .github/ fix(core): unable to find stack by name using the cli in legacy mode (aws#4998) fix(ecs-patterns): Fix issue related to protocol being passed to target group (aws#4988) chore: Backport CHANGELOG entries from v1.16.2 (aws#4980) feat(custom-resources): python handler skelaton in readme (aws#4977) fix(logs): cannot use same Lambda for multiple SubscriptionFilters (aws#4975) release: v1.16.1 (aws#4965) chore: resolve inaccurate label line in depbot config (aws#4729) chore(deps): bump aws-sdk from 2.568.0 to 2.569.0 (aws#4958)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to scope the permission for calling it from CloudWatch Logs
under the Lambda. However, when it was used multiple times there
would be a name conflict.
Instead, scope the Permission under the SubscriptionFilter.
Fixes #4951.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license