Skip to content

Conversation

@NGL321
Copy link
Contributor

@NGL321 NGL321 commented Oct 28, 2019

Dependabot config file contained a failed attempt to remove automatic labeling on pull requests.
This PR removes that line to resolve dependabot error.

Fixes: #4726

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@NGL321 NGL321 requested review from shivlaks and skinny85 October 28, 2019 20:33
@NGL321 NGL321 self-assigned this Oct 28, 2019
@mergify
Copy link
Contributor

mergify bot commented Oct 28, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist
:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@SomayaB SomayaB added the contribution/core This is a PR that came from AWS. label Oct 28, 2019
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nmussy
Copy link
Contributor

nmussy commented Oct 29, 2019

@NGL321 also fixes #4740

@mergify
Copy link
Contributor

mergify bot commented Nov 11, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 166ff74 into master Nov 11, 2019
@mergify mergify bot deleted the litovng/dependabot-fix branch November 11, 2019 22:07
arhea pushed a commit to arhea/aws-cdk that referenced this pull request Nov 19, 2019
…5-eks-patterns

* '4955-eks-patterns' of github.com:arhea/aws-cdk:
  feat(cli): adding new option to `cdk deploy` to indicate whether ChangeSet should be executed (aws#4852)
  chore: move semantic.yaml to .github/
  fix(core): unable to find stack by name using the cli in legacy mode (aws#4998)
  fix(ecs-patterns): Fix issue related to protocol being passed to target group (aws#4988)
  chore: Backport CHANGELOG entries from v1.16.2 (aws#4980)
  feat(custom-resources): python handler skelaton in readme (aws#4977)
  fix(logs): cannot use same Lambda for multiple SubscriptionFilters (aws#4975)
  release: v1.16.1 (aws#4965)
  chore: resolve inaccurate label line in depbot config (aws#4729)
  chore(deps): bump aws-sdk from 2.568.0 to 2.569.0 (aws#4958)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Your .dependabot/config.yml contained invalid details

5 participants