fix(aws-cdk-lib): feature flag report contains unnecessary flags #35227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The feature flag report generated by the core library includes flags that: - Are not configurable for CDKv2 anymore - Whose default value is the same as the recommended value (i.e., they don't need to be configured at all). At the same time, the `recommended-feature-flags.json` file does NOT contain those flags, because they aren't necessary. This means that a newly `cdk init`ed application reports that 18 flags are unconfigured by the user, producing unnecessary warnings. Instead, don't write all flags to the report, but only report on those flags that have a legitimately interesting value.
rix0rrr
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
aws-cdk-automation
previously requested changes
Aug 13, 2025
rix0rrr
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
rix0rrr
added
the
pr-linter/exempt-integ-test
rix0rrr
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
rix0rrr
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
mrgrain
approved these changes
Aug 13, 2025
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
rix0rrr
added a commit
to aws/aws-cdk-cli
that referenced
this pull request
Aug 13, 2025
The flags nag message is too pessimistic, showing 18 unconfigured flags on a newly cdk inited project. * Part of that is the CDK library emitting info for flags that don't exist anymore, fixed here: aws/aws-cdk#35227 * Part of that is we are alarming on unconfigured flags, even if the behavior of unconfigured flags is the same as recommended behavior. We shouldn't alarm on the latter, so filter them out.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature flag report generated by the core library includes flags that:
At the same time, the
recommended-feature-flags.jsonfile does NOT contain those flags, because they aren't necessary.This means that a newly
cdk inited application reports that 18 flags are unconfigured by the user, producing unnecessary warnings.We will address this in 2 parts.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license