fix(cli): displays a nag message for flags that don't need configuring #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flags nag message is too pessimistic, showing 18 unconfigured flags on a newly cdk inited project. * Part of that is the CDK library emitting info for flags that don't exist anymore, fixed here: aws/aws-cdk#35227 * Part of that is we are alarming on unconfigured flags, even if the behavior of unconfigured flags is the same as recommended behavior. We shouldn't alarm on the latter, so filter them out.
rix0rrr
had a problem deploying
to
integ-approval
GitHub Actions
Failure
rix0rrr
changed the title
rix0rrr
had a problem deploying
to
integ-approval
GitHub Actions
Failure
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #792 +/- ##
==========================================
- Coverage 81.37% 81.36% -0.02%
==========================================
Files 63 63
Lines 8555 8573 +18
Branches 1028 1033 +5
==========================================
+ Hits 6962 6975 +13
- Misses 1563 1565 +2
- Partials 30 33 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrgrain
approved these changes
Aug 13, 2025
iankhou
pushed a commit
that referenced
this pull request
Aug 21, 2025
#792) The flags nag message is too pessimistic, showing 18 unconfigured flags on a newly cdk inited project. * Part of that is the CDK library emitting info for flags that don't exist anymore, fixed here: aws/aws-cdk#35227 * Part of that is we are alarming on unconfigured flags, even if the behavior of unconfigured flags is the same as recommended behavior. We shouldn't alarm on the latter, so filter them out. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flags nag message is too pessimistic, showing 18 unconfigured flags on a newly cdk inited project.
We shouldn't alarm on the latter, so filter them out.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license