Skip to content

feat: deprecating delete existing field in ARecord #35039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 30, 2025
+3 −0
Merged

feat: deprecating delete existing field in ARecord #35039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
064cb8f
feat: deprecating delete existing field in ARecord
gasolima Jul 23, 2025
641d0d7
Merge branch 'main' into deprecate-delete-existing
ozelalisen Jul 30, 2025
ba2c768
Merge branch 'main' into deprecate-delete-existing
ozelalisen Jul 30, 2025
ddc04e7
Merge branch 'main' into deprecate-delete-existing
ozelalisen Jul 30, 2025
5cf8b06
Merge branch 'main' into deprecate-delete-existing
mergify[bot] Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions DEPRECATED_APIs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

| Module | API Element | Message |
|--------|-------------|---------|
| aws-cdk-lib/aws-route53 | RecordSetOptions.​deleteExisting | This property is dangerous and can lead to unintended record deletion in case of deployment failure.|
| @aws-cdk/core | AppProps.​runtimeInfo | use `versionReporting` instead |
| @aws-cdk/core | Arn.​parse() | use split instead |
| @aws-cdk/core | ArnComponents.​sep | use arnFormat instead |
Expand Down
2 changes: 2 additions & 0 deletions packages/aws-cdk-lib/aws-route53/lib/record-set.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ export interface RecordSetOptions {
* > an existing Record Set's `deleteExisting` property from `false -> true` after deployment
* > will delete the record!
*
* @deprecated This property is dangerous and can lead to unintended record deletion in case of deployment failure.
* @default false
*/
readonly deleteExisting?: boolean;
Expand Down Expand Up @@ -419,6 +420,7 @@ export class RecordSet extends Resource implements IRecordSet {
this.domainName = recordSet.ref;

if (props.deleteExisting) {
Annotations.of(this).addWarningV2('@aws-cdk/aws-route53:deleteExisting', 'deleteExisting field is deprecated do not use it');
// Delete existing record before creating the new one
const provider = DeleteExistingRecordSetProvider.getOrCreateProvider(this, DELETE_EXISTING_RECORD_SET_RESOURCE_TYPE, {
policyStatements: [{ // IAM permissions for all providers
Expand Down
Loading