Skip to content

Conversation

paulhcsun
Copy link
Contributor

Reverts #34013

Reverting this PR because we need to confirm that Python3.13 is available and works in all AWS regions before releasing this.

cc: @fschaeffler

@github-actions github-actions bot added the p2 label Apr 3, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team April 3, 2025 21:45
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 3, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (aac8693) to head (148f29b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #34036   +/-   ##
=======================================
  Coverage   83.98%   83.98%           
=======================================
  Files         120      120           
  Lines        6976     6976           
  Branches     1178     1178           
=======================================
  Hits         5859     5859           
  Misses       1005     1005           
  Partials      112      112           
Flag Coverage Δ
suite.unit 83.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 83.98% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@paulhcsun paulhcsun changed the title Revert "fix(s3-deployment): upgrade bucket deployment environment from python 3.11 to 3.13" revert "fix(s3-deployment): upgrade bucket deployment environment from python 3.11 to 3.13" Apr 3, 2025
@samson-keung samson-keung changed the title revert "fix(s3-deployment): upgrade bucket deployment environment from python 3.11 to 3.13" chore: reverting "fix(s3-deployment): upgrade bucket deployment environment from python 3.11 to 3.13" Apr 3, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 3, 2025 22:06

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 148f29b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@samson-keung samson-keung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

mergify bot commented Apr 3, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 74a14b3 into main Apr 3, 2025
43 checks passed
@mergify mergify bot deleted the revert-34013-fix/s3-deployment-singleton-python-version branch April 3, 2025 22:14
Copy link
Contributor

github-actions bot commented Apr 3, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants