Skip to content

Conversation

fschaeffler
Copy link
Contributor

Issue # (if applicable)

Closes #11890 (closed for staleness).

Reason for this change

S3 Bucket deployment of WebP-images with correct MIME type. As mentioned in #11890#issuecomment-2143436378 Python 3.13 brings support for the WebP MIME type.

Description of changes

Changes: Upgraded the runtime of the S3 Bucket deployment singleton function from Python 3.11 to Python 3.13.
Design Decision: None were taken.
AWS Use Cases: None were added.

Describe any new or updated permissions being added

No permissions have been added or updated.

Description of how you validated changes

The generated integration test snapshots contain now the updated Python 3.13 environment.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added feature-request A feature should be added or improved. p2 labels Apr 2, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team April 2, 2025 09:10
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Apr 2, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@fschaeffler
Copy link
Contributor Author

Exemption Request: only snapshots were updated and no integration tests were added
Clarification Request: changes are already reflected in the updated snapshots

@aws-cdk-automation aws-cdk-automation added pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Apr 2, 2025
@fschaeffler fschaeffler force-pushed the fix/s3-deployment-singleton-python-version branch from 643e228 to 5d59409 Compare April 3, 2025 06:16
@fschaeffler fschaeffler force-pushed the fix/s3-deployment-singleton-python-version branch from faae8a1 to 5aa72e3 Compare April 3, 2025 07:21
@paulhcsun paulhcsun added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Apr 3, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 3, 2025 17:15

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@paulhcsun paulhcsun removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run labels Apr 3, 2025
Copy link
Contributor

@paulhcsun paulhcsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fschaeffler, thanks for this contribution! I see that you've updated the existing integ test case to test the python3.13 runtime and I think that is sufficient. I've added the exemption label for integ tests.

@paulhcsun
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented Apr 3, 2025

update

✅ Branch has been successfully updated

@paulhcsun paulhcsun self-assigned this Apr 3, 2025
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (95c06e2) to head (ec924d9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #34013   +/-   ##
=======================================
  Coverage   83.98%   83.98%           
=======================================
  Files         120      120           
  Lines        6976     6976           
  Branches     1178     1178           
=======================================
  Hits         5859     5859           
  Misses       1005     1005           
  Partials      112      112           
Flag Coverage Δ
suite.unit 83.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 83.98% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@paulhcsun
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented Apr 3, 2025

update

✅ Branch has been successfully updated

Copy link
Contributor

mergify bot commented Apr 3, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 3, 2025
Copy link
Contributor

mergify bot commented Apr 3, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 137d27d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Apr 3, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit aac8693 into aws:main Apr 3, 2025
10 checks passed
Copy link
Contributor

github-actions bot commented Apr 3, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(@aws-cdk/aws-s3-deployment): guess mime type - webp support

3 participants