Skip to content

chore(kinesisfirehose-alpha): cleanup the alpha module after it has entered GA #33950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 27, 2025
Merged

chore(kinesisfirehose-alpha): cleanup the alpha module after it has entered GA #33950

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1f90de2
Remove Kinesis Firehose modules from alpha repo
Mar 27, 2025
4c8e1ee
Merge branch 'main' into kinesis-cleanup
Leo10Gama Mar 27, 2025
a6fb6a3
Update dependencies
Mar 27, 2025
7818275
Fix connections
Mar 27, 2025
1837691
Merge branch 'main' into kinesis-cleanup
mergify[bot] Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions packages/@aws-cdk/aws-kinesisfirehose-alpha/.eslintrc.js
View file
Open in desktop
Copy link
Member

@godwingrs22 godwingrs22 Mar 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to other, we might need to change the reference to the stable module package wherever currently referenced.

  1. modules-enums.json
  2. classes.ts
  3. packages.json

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Echoing my comment on the identitypool PR:

For the classes.ts, the header mentions not to edit the file manually, since an automated GitHub workflow maintains it. The enum JSON files are similar, but those ones are linked to a script that's still manual, but again is maintained by automation. So I think it should be fine to leave these untouched for now.

This file was deleted.

25 changes: 0 additions & 25 deletions packages/@aws-cdk/aws-kinesisfirehose-alpha/.gitignore
View file
Open in desktop

This file was deleted.

29 changes: 0 additions & 29 deletions packages/@aws-cdk/aws-kinesisfirehose-alpha/.npmignore
View file
Open in desktop

This file was deleted.

201 changes: 0 additions & 201 deletions packages/@aws-cdk/aws-kinesisfirehose-alpha/LICENSE
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions packages/@aws-cdk/aws-kinesisfirehose-alpha/NOTICE
View file
Open in desktop

This file was deleted.

Loading