-
Notifications
You must be signed in to change notification settings - Fork 4.3k
chore(kinesisfirehose-alpha): cleanup the alpha module after it has entered GA #33950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33950 +/- ##
=======================================
Coverage 82.38% 82.38%
=======================================
Files 120 120
Lines 6955 6955
Branches 1173 1173
=======================================
Hits 5730 5730
Misses 1120 1120
Partials 105 105
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to other, we might need to change the reference to the stable module package wherever currently referenced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Echoing my comment on the identitypool PR:
For the
classes.ts, the header mentions not to edit the file manually, since an automated GitHub workflow maintains it. The enum JSON files are similar, but those ones are linked to a script that's still manual, but again is maintained by automation. So I think it should be fine to leave these untouched for now.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
The
kinesisfirehoseandkinesisfirehose-destinationsmodules were recently stabilized to GA in PR #33296. As such, we have no need for the alpha module any more.Description of changes
Description of how you validated changes
yarn install && npx lerna run build --skip-nx-cacherun successfully.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license