feat(CLI): Diff Supports Import Change Sets #28787
Conversation
comcalvi
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
added
the
pr/needs-cli-test-run
comcalvi
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
comcalvi
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
comcalvi
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
comcalvi
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
comcalvi
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
comcalvi
temporarily deployed
to
test-pipeline
GitHub Actions
Inactive
comcalvi
added
pr-linter/exempt-readme
comcalvi
temporarily deployed
to
test-pipeline
GitHub Actions
Inactive
|
This is causing a failure in the integ test pipeline. Let's get that fixed before reviewing the change. |
comcalvi
temporarily deployed
to
test-pipeline
GitHub Actions
Inactive
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
comcalvi
added
pr-linter/cli-integ-tested
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
#28336 made diff create and parse change sets to determine accurate resource replacement information. This PR expands the change set parsing to support import type change sets. This shows the output of diff with a single resource import: <img width="1609" alt="Screenshot 2024-01-19 at 2 44 09 PM" src="https://github.com/aws/aws-cdk/assets/66279577/a67761fa-f0aa-4cb1-b8ec-049e116400b6"> ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
#28336 made diff create and parse change sets to determine accurate resource replacement information. This PR expands the change set parsing to support import type change sets.
This shows the output of diff with a single resource import:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license