fix(cli): cdk diff falsely reports resource replacements on trivial template changes
#28336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mic vs evaluation: direct to show supposedly always replacement updates that are actually 'maybe' updates
comcalvi
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
aws-cdk-automation
previously requested changes
Dec 12, 2023
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
added
the
pr/needs-cli-test-run
comcalvi
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
comcalvi
added
the
pr-linter/exempt-integ-test
comcalvi
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
comcalvi
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
comcalvi
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
comcalvi
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
comcalvi
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
comcalvi
added
pr-linter/cli-integ-tested
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
rix0rrr
approved these changes
Jan 4, 2024
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
paulhcsun
pushed a commit
to paulhcsun/aws-cdk
that referenced
this pull request
Jan 5, 2024
… template changes (aws#28336) Adds a new flag to diff, `--change-set`, that creates a new changeset and uses it to determine resource replacement. This new flag is on by default. When the flag is set, the following happens: * Resource metadata changes are obscured * Resource changes that do not appear in the changeset are obscured from the diff When the flag is unset, yaml Fn::GetAtt short-form uses are considered equivalent to their long-form counterpart. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
3 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
#28336 made diff create and parse change sets to determine accurate resource replacement information. This PR expands the change set parsing to support import type change sets. This shows the output of diff with a single resource import: <img width="1609" alt="Screenshot 2024-01-19 at 2 44 09 PM" src="https://github.com/aws/aws-cdk/assets/66279577/a67761fa-f0aa-4cb1-b8ec-049e116400b6"> ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
SankyRed
pushed a commit
that referenced
this pull request
Feb 8, 2024
#28336 made diff create and parse change sets to determine accurate resource replacement information. This PR expands the change set parsing to support import type change sets. This shows the output of diff with a single resource import: <img width="1609" alt="Screenshot 2024-01-19 at 2 44 09 PM" src="https://github.com/aws/aws-cdk/assets/66279577/a67761fa-f0aa-4cb1-b8ec-049e116400b6"> ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Feb 10, 2024
k-asm
added a commit
to k-asm/cdk_plan_action
that referenced
this pull request
Feb 22, 2024
diffTemplate became a private function from the following PR aws/aws-cdk#28336
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new flag to diff,
--change-set, that creates a new changeset and uses it to determine resource replacement. This new flag is on by default.When the flag is set, the following happens:
When the flag is unset, yaml Fn::GetAtt short-form uses are considered equivalent to their long-form counterpart.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license