fix(redshift): enableRebootForParameterChanges fails synth with "cannot find entry file…" #28760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t find entry file...
aws-cdk-automation
previously requested changes
Jan 18, 2024
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
paulhcsun
added
pr-linter/exempt-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-maintainer-review
kaizencc
requested changes
Jan 19, 2024
There was a problem hiding this comment.
Some documentation changes and then we're all good. Thanks @paulhcsun
| awscdklibdir=${scriptdir}/.. | ||
|
|
||
| function airlift() { | ||
| # core needs to be airlifted directly to core to prevent circular dependencies |
There was a problem hiding this comment.
is this comment still relevant?
| - aws-amplify-alpha/asset-deployment-handler | ||
|
|
||
| These handlers are excluded from `aws-cdk-lib/custom-resource-handlers` and are individually | ||
| copied into their respective `-alpha` packages at build time. When an `-alpha` package is | ||
| stabilized, part of the stabilization process **must** be to remove `-alpha` from the folder | ||
| name, so that it is included in `aws-cdk-lib`. | ||
|
|
||
| `*/generated.ts` files are not supported for alpha modules due to import paths that only work for stable modules in `aws-cdk-lib`. |
There was a problem hiding this comment.
Explain that they must be added into custom-resources-framework/config.ts as ComponentType.NO_OP
| @@ -15,13 +15,16 @@ and included as part of the `aws-cdk-lib` package. | |||
|
|
|||
| ### Experimental: | |||
|
|
|||
| - aws-amplify-alpha/asset-deployment-handler | |||
aws-cdk-automation
removed
the
pr/needs-maintainer-review
kaizencc
approved these changes
Jan 19, 2024
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify bot
pushed a commit
that referenced
this pull request
Feb 2, 2024
This is a follow up to #28658, #28772, and #28760. We had to fix multiple places where that file path extended beyond the package itself into other areas of the local repository (that would not be available after packaging). This caused myriad issues at synth time with `file not found` errors. This PR introduces a linter rule with the following specifications: - no inefficient paths, i.e. no going backwards multiple times. Ex. `path.join(__dirname, '..', 'folder', '..', 'another-folder')`. This should and can be easily simplified - no paths that go backwards past a `package.json` file. This should catch the instances we faced next time. The `yarn lint` command on `aws-cdk-lib` took 51.47s seconds without this new rule and 53.32s seconds with the rule enabled. The difference of ~2 seconds shouldn't be a hindrance in this case but I am happy to look for additional efficiencies in the rule I've written. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
SankyRed
pushed a commit
that referenced
this pull request
Feb 8, 2024
This is a follow up to #28658, #28772, and #28760. We had to fix multiple places where that file path extended beyond the package itself into other areas of the local repository (that would not be available after packaging). This caused myriad issues at synth time with `file not found` errors. This PR introduces a linter rule with the following specifications: - no inefficient paths, i.e. no going backwards multiple times. Ex. `path.join(__dirname, '..', 'folder', '..', 'another-folder')`. This should and can be easily simplified - no paths that go backwards past a `package.json` file. This should catch the instances we faced next time. The `yarn lint` command on `aws-cdk-lib` took 51.47s seconds without this new rule and 53.32s seconds with the rule enabled. The difference of ~2 seconds shouldn't be a hindrance in this case but I am happy to look for additional efficiencies in the rule I've written. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TheRealAmazonKendra
pushed a commit
that referenced
this pull request
Feb 9, 2024
This is a follow up to #28658, #28772, and #28760. We had to fix multiple places where that file path extended beyond the package itself into other areas of the local repository (that would not be available after packaging). This caused myriad issues at synth time with `file not found` errors. This PR introduces a linter rule with the following specifications: - no inefficient paths, i.e. no going backwards multiple times. Ex. `path.join(__dirname, '..', 'folder', '..', 'another-folder')`. This should and can be easily simplified - no paths that go backwards past a `package.json` file. This should catch the instances we faced next time. The `yarn lint` command on `aws-cdk-lib` took 51.47s seconds without this new rule and 53.32s seconds with the rule enabled. The difference of ~2 seconds shouldn't be a hindrance in this case but I am happy to look for additional efficiencies in the rule I've written. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error:
This PR fixes the same issue detailed in #28658 but for
aws-redshift-alphaas both modules have the same issue with accessingcustom-resource-handlers.This PR uses the same airlift mechanism as
aws-cdk-libto move the necessary files into theaws-redshift-alphapackage so its structure now looks like this:The airlift script only moves the
index.jsfile and not the*/generated.tsfiles because imports in alpha module*/generated.tsfiles do not currently work since the import paths were written to only support stable modules inaws-cdk-lib.I've tested the
aws-redshift-alphapackage locally on a local CDK app and confirmed the necessary structure exists in the packaged module. The local app calls thecluster.enableRebootForParameterChanges()method which creates the custom resource and I was able to verify that the cluster deploys properly and is rebootable.Related to #28633 but this is the fix for
aws-redshift-alphaBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license