Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amplify-alpha: addBranch fails #28879

Open
PetroLiubynskyi opened this issue Jan 26, 2024 · 3 comments
Open

amplify-alpha: addBranch fails #28879

PetroLiubynskyi opened this issue Jan 26, 2024 · 3 comments
Labels
@aws-cdk/aws-amplify Related to AWS Amplify bug This issue is a bug. effort/medium Medium work item – several days of effort p3

Comments

@PetroLiubynskyi
Copy link

Describe the bug

Previously resolved issue allows to make a step forward, but the whole process of deployment of angular app to Amplify still does not work.

The following error appears during cdk deploy execution

image
.....
image
.....
`Bundling asset /com.amazonaws.cdk.custom-resources.amplify-asset-deployment-provider/amplify-asset-deployment-on-event/Code/Stage...
esbuild cannot run locally. Switching to Docker bundling.

✘ [ERROR] Could not resolve "/tmp/jsii-kernel-yOr44c/node_modules/@aws-cdk/aws-amplify-alpha/custom-resource-handlers/dist/aws-amplify-alpha/asset-deployment-handler/index.js"
`

Expected Behavior

Amplify branch should be created from an asset

Current Behavior

Amplify branch is not created from an asset

Reproduction Steps

Execute the code

amplify_app = amplify.App(
            self, 
            "Amplify",
            app_name="my-app",
            platform=amplify.Platform.WEB
        )

deployed_bundle = assets.Asset(
            self,
            "DeployedBundle",
            path=bundle_path)

amplify_app.add_branch(
            "AmplifyBranch",
            branch_name=env,
            asset=deployed_bundle,
            auto_build=False,
            pull_request_preview=False
        )

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

aws-cdk.aws-amplify-alpha==2.123.0a0

Framework Version

aws-cdk-lib==2.123.0

Node.js Version

18.14.0

OS

Windows 11 Pro

Language

Python

Language Version

3.10.11

Other information

No response

@PetroLiubynskyi PetroLiubynskyi added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jan 26, 2024
@github-actions github-actions bot added the @aws-cdk/aws-amplify Related to AWS Amplify label Jan 26, 2024
@PetroLiubynskyi PetroLiubynskyi changed the title @aws-cdk\aws-amplify-alpha: addBranch fails with docker error @aws-cdk\aws-amplify-alpha: addBranch fails Jan 26, 2024
@pahud
Copy link
Contributor

pahud commented Jan 29, 2024

probably related to #28764. Is it still failing in the latest cdk v2.124.0 ?

@pahud pahud added p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jan 29, 2024
Copy link

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Jan 31, 2024
@PetroLiubynskyi
Copy link
Author

probably related to #28764. Is it still failing in the latest cdk v2.124.0 ?

The funny thing that it is not. Because there were 2 issues: #28764 and previously created by me #28633 that were closed by #28760

This allowed me to make a step forward and to see that cdk deploy at least started. But the same error appears later in the flow.

@github-actions github-actions bot removed closing-soon This issue will automatically close in 4 days unless further comments are made. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels Feb 2, 2024
@pahud pahud changed the title @aws-cdk\aws-amplify-alpha: addBranch fails amplify-alpha: addBranch fails Jun 3, 2024
@pahud pahud added p3 and removed p2 labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-amplify Related to AWS Amplify bug This issue is a bug. effort/medium Medium work item – several days of effort p3
Projects
None yet
Development

No branches or pull requests

2 participants