feat(aws-dynamodb-global): Adding package to support DynamoDB Global Tables #2251

KingOfPoptart · 2019-04-11T23:38:42Z

Adding a new package to support AWS DynamoDB Global Tables. The new package is built on top the existing aws-dynamodb package.

The construct creates multiple stacks in the specified regions, each with a DynamoDB Table (using the aws-dynamodb package). A custom resource is then deployed and uses a lambda to tie the tables together into a multi-region, multi-master database.

Pull Request Checklist

Testing
- Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
- CLI change?: coordinate update of integration tests with team
- cdk-init template change?: coordinated update of integration tests with team
Docs
- jsdocs: All public APIs documented
- README: README and/or documentation topic updated
Title and Description
- Change type: title prefixed with fix, feat will appear in changelog
- Title: use lower-case and doesn't end with a period
- Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
- Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
Sensitive Modules (requires 2 PR approvers)
- IAM Policy Document (in @aws-cdk/aws-iam)
- EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
- Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

Pull master

Update to 0.28

Update from master

fix(decdk): set the timeout in the schema tests to 10 seconds. (#2250)

fix(codebuild): add validation for Source when the badge property is …

…true (#2242) Badge should not be allowed to be true if Source is not of type GitHub, GitHub Enterprise or Bitbucket. Fixes #1749 AWS DynamoDB Global Tables package for CDK

…Poptart/aws-cdk into KingOfPoptart/aws-dynamodb-global

KingOfPoptart · 2019-04-11T23:40:01Z

So for clarity - I completely screwed up my previous PR (rebasing nightmare from waiting 20+ days between starting and getting ready to merge), so I'm creating this one to replace it. Old PR can be found here - #2082

eladb

A few more comments...

eladb · 2019-04-15T15:57:36Z

packages/@aws-cdk/aws-dynamodb-global/lib/lambda-global-dynamodb.ts

+   * Permits an IAM Principal to create a global dynamodb table.
+   * @param principal The principal (no-op if undefined)
+   */
+  public static grantCreateGlobalTableLambda(principal?: iam.IPrincipal): void {


Why does this need to be public? Seems like it's basically a helper used only in this file.

eladb · 2019-04-15T15:59:05Z

packages/@aws-cdk/aws-dynamodb-global/lib/aws-dynamodb-global.ts

+
+    this.lambdaGlobalDynamodbMaker = new LambdaGlobalDynamoDBMaker(scope, id + "-CustomResource", props);
+    for (const table of this._regionalTables) {
+      this.lambdaGlobalDynamodbMaker.customResource.node.addDependency(table);


I believe (not 100% sure) that if you just do this.lambdaGlobalDynamodbMaker.node.addDependency(table) it will automatically add a dependency on all underlying resources

eladb · 2019-04-15T16:03:38Z

packages/@aws-cdk/aws-dynamodb-global/lib/lambda-global-dynamodb.ts

+ * A stack that will make a Lambda that will launch a lambda to glue
+ * together all the DynamoDB tables into a global table
+ */
+export class LambdaGlobalDynamoDBMaker extends cdk.Stack {


Sorry for nitpicking, I am a bit sensitive to naming. Can you rename this to GlobalTableCoordinator (it's an internal class, I know...).

eladb · 2019-04-15T16:04:02Z

packages/@aws-cdk/aws-dynamodb-global/lib/lambda-global-dynamodb.ts

+      lambdaProvider: this.lambdaFunction,
+      properties: {
+        regions: props.regions,
+        resourceType: "Custom::MakeGlobalDynamoDB",


Rename to Custom::DynamoGlobalTableCoordinator

eladb · 2019-04-15T16:04:26Z

packages/@aws-cdk/aws-dynamodb-global/package.json

+      "sphinx": {}
+    }
+  },
+  "cdk-build": {


Remove this from here... It's only for the aws-dynamodb package

eladb

Looks awesome. Thanks for all the hard work!

eladb · 2019-04-16T05:11:05Z

@KingOfPoptart do you mind taking a few minutes finalizing the PR title and message so we can use them for the merge commit?

KingOfPoptart · 2019-04-16T05:21:10Z

@eladb updated! Let me know if that's sufficient.

KingOfPoptart and others added 8 commits March 20, 2019 09:52

Merge pull request #1 from awslabs/master

9580b32

Pull master

Merge pull request #3 from awslabs/master

25bea4a

Update to 0.28

Merge pull request #4 from awslabs/master

670894b

Update from master

Merge pull request #5 from awslabs/master

f93a7a6

fix(decdk): set the timeout in the schema tests to 10 seconds. (#2250)

Merge pull request #6 from awslabs/master

edce23d

fix(codebuild): add validation for Source when the badge property is …

AWS DynamoDB Global Tables package for CDK

4de7c0e

fix(codebuild): add validation for Source when the badge property is …

cd9d083

…true (#2242) Badge should not be allowed to be true if Source is not of type GitHub, GitHub Enterprise or Bitbucket. Fixes #1749 AWS DynamoDB Global Tables package for CDK

Merge branch 'KingOfPoptart/aws-dynamodb-global' of github.com:KingOf…

1355ed7

…Poptart/aws-cdk into KingOfPoptart/aws-dynamodb-global

KingOfPoptart requested a review from a team as a code owner April 11, 2019 23:38

KingOfPoptart mentioned this pull request Apr 12, 2019

feat(aws-dynamodb-global): support for global dynamodb tables #2082

Closed

4 tasks

RomainMuller assigned RomainMuller and eladb and unassigned RomainMuller Apr 15, 2019

Stylistic changes

28e2475

eladb reviewed Apr 15, 2019

View reviewed changes

Code Review

0a0e946

eladb approved these changes Apr 16, 2019

View reviewed changes

KingOfPoptart changed the title ~~feat(aws-dynamodb-global): Package for Global DynamoDB Tables~~ feat(aws-dynamodb-global): Adding package to support Global DynamoDB Tables Apr 16, 2019

KingOfPoptart changed the title ~~feat(aws-dynamodb-global): Adding package to support Global DynamoDB Tables~~ feat(aws-dynamodb-global): Adding package to support DynamoDB Global Tables Apr 16, 2019

eladb merged commit ec367c8 into aws:master Apr 16, 2019

KingOfPoptart deleted the KingOfPoptart/aws-dynamodb-global branch April 16, 2019 17:04

skinny85 mentioned this pull request Jun 20, 2019

Tighten down permissions for the DynamoDB Global Table custom resource #2968

Closed

This was referenced Dec 12, 2019

[Snyk] Upgrade @aws-cdk/cdk from 0.22.0 to 0.35.0 MechanicalRock/scdk#3

Closed

[Snyk] Upgrade @aws-cdk/cdk from 0.24.1 to 0.35.0 MechanicalRock/cdk-constructs#8

Open

[Snyk] Upgrade @aws-cdk/cdk from 0.24.1 to 0.35.0 MechanicalRock/account-reaper#6

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(aws-dynamodb-global): Adding package to support DynamoDB Global Tables #2251

feat(aws-dynamodb-global): Adding package to support DynamoDB Global Tables #2251

KingOfPoptart commented Apr 11, 2019 •

edited

Loading

KingOfPoptart commented Apr 11, 2019

eladb left a comment

eladb Apr 15, 2019

eladb Apr 15, 2019

eladb Apr 15, 2019

eladb Apr 15, 2019

eladb Apr 15, 2019

eladb left a comment

eladb commented Apr 16, 2019

KingOfPoptart commented Apr 16, 2019

feat(aws-dynamodb-global): Adding package to support DynamoDB Global Tables #2251

feat(aws-dynamodb-global): Adding package to support DynamoDB Global Tables #2251

Conversation

KingOfPoptart commented Apr 11, 2019 • edited Loading

Pull Request Checklist

KingOfPoptart commented Apr 11, 2019

eladb left a comment

Choose a reason for hiding this comment

eladb Apr 15, 2019

Choose a reason for hiding this comment

eladb Apr 15, 2019

Choose a reason for hiding this comment

eladb Apr 15, 2019

Choose a reason for hiding this comment

eladb Apr 15, 2019

Choose a reason for hiding this comment

eladb Apr 15, 2019

Choose a reason for hiding this comment

eladb left a comment

Choose a reason for hiding this comment

eladb commented Apr 16, 2019

KingOfPoptart commented Apr 16, 2019

KingOfPoptart commented Apr 11, 2019 •

edited

Loading