Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(codebuild): add validation for source when badge is enabled #2242

Merged
merged 3 commits into from
Apr 11, 2019
Merged

fix(codebuild): add validation for source when badge is enabled #2242

merged 3 commits into from
Apr 11, 2019

Conversation

Kaixiang-AWS
Copy link
Contributor

Badge should not be allow to set to true if source is not GITHUB, GITHUB_ENTERPRISE or BITBUCKET

Fixes #1749

Pull Request Checklist

  • [Y] Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • [Y] Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • [Y] Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • [N] Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@Kaixiang-AWS
fix(codebuild): add validation for source when badge is enabled
59c0282 
Badge should not be allow to set to true if source is not GITHUB, GITHUB_ENTERPRISE or BITBUCKET

Fixes aws#1749
@eladb
Copy link
Contributor

eladb commented Apr 11, 2019

LGTM; @skinny85 I'll let you merge

eladb
eladb reviewed Apr 11, 2019
View reviewed changes
packages/@aws-cdk/aws-codebuild/lib/source.ts Outdated
@@ -22,6 +22,7 @@ export interface BuildSourceProps {
export abstract class BuildSource {
public readonly identifier?: string;
public abstract readonly type: SourceType;
public readonly badgeAllowed: boolean = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think badgeSupported makes more sense than allowed

skinny85
skinny85 approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :) Feel free to change the name to badgeSupported, according to Elad's suggestion.

@skinny85 skinny85 merged commit 07812b2 into aws:master Apr 11, 2019
@Kaixiang-AWS Kaixiang-AWS deleted the badge branch May 14, 2019 04:14
This was referenced Dec 12, 2019
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb left review comments

@RomainMuller RomainMuller RomainMuller left review comments

@skinny85 skinny85 skinny85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: PipelineProject badge error
4 participants
@Kaixiang-AWS @eladb @RomainMuller @skinny85