Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codepipeline): remove the aws-codepipeline-api package #2191

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

skinny85
Copy link
Contributor

@skinny85 skinny85 commented Apr 5, 2019

Fixes #2157


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@skinny85 skinny85 requested a review from eladb April 5, 2019 20:53
@skinny85 skinny85 requested review from RomainMuller and a team as code owners April 5, 2019 20:53
Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be turned into a deprecation notice instead..... Like we did for @aws-cdk/aws-sam in #2110, and only delete the package for the next release. Note that - you should set the deprecated attribute in package.json to the actual deprecation string instead of a boolean (that's a nifty, undocumented feature of npmjs :D).

@skinny85
Copy link
Contributor Author

skinny85 commented Apr 8, 2019

This package was effectively "deprecated" when #2098 was merged. I say "deprecated" in quotes, as I didn't know about this NPM feature, so I didn't set the deprecated attribute in package.json. However, I did remove all of the code from the package, and left it practically empty.

Since then, there was a release of the CDK with this empty shell version of this package, 0.28.0. Hence why we want to remove it now.

Are you OK with this @RomainMuller , or do you want to release this package one more time, in 0.29.0, in this empty shell version, just with the added deprecated attribute in package.json?

@skinny85
Copy link
Contributor Author

skinny85 commented Apr 9, 2019

@RomainMuller ping

@skinny85 skinny85 force-pushed the feature/remove-cp-api-module branch from 3e5e0d6 to 6f0cada Compare April 12, 2019 17:11
@skinny85
Copy link
Contributor Author

Rebased to solve the conflict.

@skinny85 skinny85 force-pushed the feature/remove-cp-api-module branch from 6f0cada to ad98e2d Compare April 12, 2019 17:20
@skinny85
Copy link
Contributor Author

Removed the package.json which was resolved as an empty file in the conflict instead of being removed.

@RomainMuller RomainMuller merged commit f7a5c6c into aws:master Apr 16, 2019
@skinny85 skinny85 deleted the feature/remove-cp-api-module branch April 16, 2019 17:03
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove aws-codepipeline-api after next release
4 participants